New issue
Advanced search Search tips

Issue 634642 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Set an image link in the /etc/lsb-release file of all images

Project Member Reported by xixuan@chromium.org, Aug 5 2016

Issue description

From /etc/lsb_release file of DUT, it's easy to get the version/board/milestone of the current image on this DUT. However, only based on these infos, we can't form a downloadable image link which could be used by devserver to download the image packages. 

We want to add this feature to /etc/lsb_release.

 
Summary: Set an image link in the /etc/lsb-release file of all images (was: Get the image link of the current image that the DUT has)

Comment 2 by xixuan@chromium.org, Aug 12 2016

Cc: xixuan@chromium.org
 Issue 471906  has been merged into this issue.

Comment 3 by xixuan@chromium.org, Aug 12 2016

Set CHROMEOS_BUILDER_PATH= such following strings in etc/lsb-release.
    peppy-release/R42-6802.0.0
    link-paladin/R42-6807.0.0-rc5
    daisy-chromium-pfq/R42-6807.0.0-rc2

or for trybots:
    trybot-x86-mario-paladin/R54-8697.0.0-b1271  (with trybot prefix)

of no this line if someone build_image on their desktop without passing in any parameters.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/4a5af05a5f8ee567091bd2f5db8857a5361e25cb

commit 4a5af05a5f8ee567091bd2f5db8857a5361e25cb
Author: xixuan <xixuan@google.com>
Date: Thu Aug 04 02:20:38 2016

cbuildbot scripts: Add an builder_path entry to /etc/lsb_release file on the
DUT.

Current image's /etc/lsb-release file does not include the whole image name.
For example, it only contains board (lumpy), version (8667.0.0), and milstone
(54), which cannot be used to create a recognizable image name, like
lumpy-paladin/R54-8667.0.0, for devserver to download its packages.

This CL add this info as CHROMEOS_RELEASE_BUILDER_PATH to the /etc/lsb-release
file of any built images.

BUG= chromium:634642 
TEST=trybot success.
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/
paladin/builds/1290.
Run build_image locally without/with builder_path entry.
CQ-DEPEND=CL:366130

Change-Id: I9a80a5137cf567bdf63845a9182e1191f5b82d97
Reviewed-on: https://chromium-review.googlesource.com/366056
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/4a5af05a5f8ee567091bd2f5db8857a5361e25cb/build_library/base_image_util.sh
[modify] https://crrev.com/4a5af05a5f8ee567091bd2f5db8857a5361e25cb/build_image

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/745999f789d4cebbe637f9350e085114d7aa2c7c

commit 745999f789d4cebbe637f9350e085114d7aa2c7c
Author: xixuan <xixuan@google.com>
Date: Thu Aug 04 02:20:30 2016

chromite: Add an builder_path to /etc/lsb-release file of the DUT.

This CL adds a line 'CHROMEOS_RELEASE_BUILDER_PATH' to the /etc/lsb-release
file of images. The link's format is like 'lumpy-paladin/R54-8667.0.0'.

BUG= chromium:634642 
TEST=trybot success.
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/
paladin/builds/1290.
Run build_image locally without/with builder_path entry.
CQ-DEPEND=CL:366056

Change-Id: I2539243b3ce26e4dc3b39065792477900bbcb821
Reviewed-on: https://chromium-review.googlesource.com/366130
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/745999f789d4cebbe637f9350e085114d7aa2c7c/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/745999f789d4cebbe637f9350e085114d7aa2c7c/cbuildbot/commands.py
[modify] https://crrev.com/745999f789d4cebbe637f9350e085114d7aa2c7c/scripts/cros_set_lsb_release.py

Status: Fixed (was: Assigned)

Comment 7 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 8 by dchan@chromium.org, Oct 10 2016

Labels: -VerifyIn-55

Comment 9 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 10 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment