MD Settings: extra overscroll in pages and expanded sections |
|||||||
Issue descriptionThere's now up to 64px of extra scrollable space below expanded cards, means they're no longer full-height. There's also 64px of space underneath the About page and the Advanced page (even with 0 overscroll). I think https://codereview.chromium.org/2206723002 shouldn't force a margin on ALL pages, and shouldn't show at all if a section is expanded.
,
Aug 10 2016
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1a80c952130760f4401d6c945f40cfb8ced6ddd commit e1a80c952130760f4401d6c945f40cfb8ced6ddd Author: michaelpg <michaelpg@chromium.org> Date: Fri Aug 19 02:05:16 2016 MD Settings: methods to get root pages and sections BUG= 634582 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2230753002 Cr-Commit-Position: refs/heads/master@{#413024} [modify] https://crrev.com/e1a80c952130760f4401d6c945f40cfb8ced6ddd/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp [modify] https://crrev.com/e1a80c952130760f4401d6c945f40cfb8ced6ddd/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/e1a80c952130760f4401d6c945f40cfb8ced6ddd/chrome/browser/resources/settings/settings_page/main_page_behavior.js
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59ce449c58b384906bcd2c0c66826c6ce69ad047 commit 59ce449c58b384906bcd2c0c66826c6ce69ad047 Author: michaelpg <michaelpg@chromium.org> Date: Fri Aug 19 05:41:19 2016 MD Settings: Never underscroll Changing the overscroll amount can force the page to scroll unexpectedly. Never change the overscroll to less than the current visible overscroll. R=dschuyler@chromium.org BUG= 634582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2228783005 Cr-Commit-Position: refs/heads/master@{#413058} [modify] https://crrev.com/59ce449c58b384906bcd2c0c66826c6ce69ad047/chrome/browser/resources/settings/settings_main/settings_main.js
,
Aug 23 2016
Issue 639746 has been merged into this issue.
,
Sep 20 2016
,
Sep 24 2016
Issue 647195 has been merged into this issue.
,
Sep 30 2016
Issue 650904 has been merged into this issue.
,
Nov 28 2016
,
Dec 9 2016
,
Mar 16 2017
This appears to have already been fixed (I know it was an issue in the past). Marking wontFix since it's good now. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dschuyler@chromium.org
, Aug 5 2016