[ARC++] fullscreen/maximized arc apps in overview mode has space around it. |
|||||||
Issue descriptionThis is because the maximized/fullscreen window in chrome ignore set bounds request, thus does not match geometry. I'll work on this probably next week.
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b commit e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b Author: oshima <oshima@chromium.org> Date: Mon Aug 15 18:57:31 2016 Allow updating arc widget bounds in maximize/fullscreen state. ARC window can be pillar/letterboxed in maximized state, and chrome needs to adjust its window to those sizes. BUG= 634572 R=reveman@chromium.org TEST=WindowStateTest.AllowSetBoundsInMaximized Manually tested on minnie Review-Url: https://codereview.chromium.org/2237983002 Cr-Commit-Position: refs/heads/master@{#412006} [modify] https://crrev.com/e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b/ash/common/wm/default_state.cc [modify] https://crrev.com/e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b/ash/common/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b/ash/common/wm/window_state.h [modify] https://crrev.com/e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b/ash/wm/window_state_unittest.cc [modify] https://crrev.com/e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b/components/exo/shell_surface.cc [modify] https://crrev.com/e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b/components/exo/shell_surface_unittest.cc
,
Aug 15 2016
,
Aug 15 2016
Oshima@ has this been validated on ToT?
,
Aug 16 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e26c7e4886eec4d2c58a5810b6440f7faa4293ea commit e26c7e4886eec4d2c58a5810b6440f7faa4293ea Author: oshima <oshima@chromium.org> Date: Tue Aug 16 23:55:40 2016 ResetFocusRestoreWindow may change activation, which can resize the window, which then results in reposition. This prevents it by updating the focus after grids are shutdown. BUG= 634572 Review-Url: https://codereview.chromium.org/2244173006 Cr-Commit-Position: refs/heads/master@{#412384} [modify] https://crrev.com/e26c7e4886eec4d2c58a5810b6440f7faa4293ea/ash/common/wm/overview/window_selector.cc
,
Aug 17 2016
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0563bb605d6d4596510d7d65d0b1041632287402 commit 0563bb605d6d4596510d7d65d0b1041632287402 Author: oshima <oshima@chromium.org> Date: Wed Aug 17 18:58:44 2016 Revert of Reset the focus after windows are restored, and grids are shutdown. (patchset #4 id:60001 of https://codereview.chromium.org/2244173006/ ) Reason for revert: Reverting because this can cause crash with arc++ windows. Original issue's description: > ResetFocusRestoreWindow may change activation, which can resize the window, which then results in reposition. This prevents it by updating the focus after grids are shutdown. > > BUG= 634572 > > Committed: https://crrev.com/e26c7e4886eec4d2c58a5810b6440f7faa4293ea > Cr-Commit-Position: refs/heads/master@{#412384} TBR=varkha@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 634572 Review-Url: https://codereview.chromium.org/2251053003 Cr-Commit-Position: refs/heads/master@{#412602} [modify] https://crrev.com/0563bb605d6d4596510d7d65d0b1041632287402/ash/common/wm/overview/window_selector.cc
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbe0bdc738e50b89b5bffb25e431e6b6e75a4249 commit bbe0bdc738e50b89b5bffb25e431e6b6e75a4249 Author: oshima <oshima@chromium.org> Date: Wed Aug 17 22:44:48 2016 Don't reposition if shutdown is in progress BUG= 634572 Review-Url: https://codereview.chromium.org/2249853009 Cr-Commit-Position: refs/heads/master@{#412675} [modify] https://crrev.com/bbe0bdc738e50b89b5bffb25e431e6b6e75a4249/ash/common/wm/overview/window_grid.cc [modify] https://crrev.com/bbe0bdc738e50b89b5bffb25e431e6b6e75a4249/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/bbe0bdc738e50b89b5bffb25e431e6b6e75a4249/ash/common/wm/overview/window_selector.h
,
Aug 17 2016
This has been tested on ToT.
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c483f1a73d3ca005269f50bfa272abbdf9e2b2d commit 4c483f1a73d3ca005269f50bfa272abbdf9e2b2d Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Aug 17 23:38:17 2016 Allow updating arc widget bounds in maximize/fullscreen state. ARC window can be pillar/letterboxed in maximized state, and chrome needs to adjust its window to those sizes. BUG= 634572 TBR=reveman@chromium.org TEST=WindowStateTest.AllowSetBoundsInMaximized Manually tested on minnie Review-Url: https://codereview.chromium.org/2237983002 Cr-Commit-Position: refs/heads/master@{#412006} (cherry picked from commit e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b) Review URL: https://codereview.chromium.org/2250713006 . Cr-Commit-Position: refs/branch-heads/2785@{#646} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/4c483f1a73d3ca005269f50bfa272abbdf9e2b2d/ash/common/wm/default_state.cc [modify] https://crrev.com/4c483f1a73d3ca005269f50bfa272abbdf9e2b2d/ash/common/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/4c483f1a73d3ca005269f50bfa272abbdf9e2b2d/ash/common/wm/window_state.h [modify] https://crrev.com/4c483f1a73d3ca005269f50bfa272abbdf9e2b2d/ash/wm/window_state_unittest.cc [modify] https://crrev.com/4c483f1a73d3ca005269f50bfa272abbdf9e2b2d/components/exo/shell_surface.cc [modify] https://crrev.com/4c483f1a73d3ca005269f50bfa272abbdf9e2b2d/components/exo/shell_surface_unittest.cc
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b67fa253af23fe7fa638ac27a95594cdc3b526d commit 8b67fa253af23fe7fa638ac27a95594cdc3b526d Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Aug 17 23:54:17 2016 Don't reposition if shutdown is in progress BUG= 634572 Review-Url: https://codereview.chromium.org/2249853009 Cr-Commit-Position: refs/heads/master@{#412675} (cherry picked from commit bbe0bdc738e50b89b5bffb25e431e6b6e75a4249) Review URL: https://codereview.chromium.org/2252833004 . Cr-Commit-Position: refs/branch-heads/2785@{#647} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/8b67fa253af23fe7fa638ac27a95594cdc3b526d/ash/common/wm/overview/window_grid.cc [modify] https://crrev.com/8b67fa253af23fe7fa638ac27a95594cdc3b526d/ash/common/wm/overview/window_selector.cc [modify] https://crrev.com/8b67fa253af23fe7fa638ac27a95594cdc3b526d/ash/common/wm/overview/window_selector.h
,
Aug 18 2016
,
Oct 5 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by osh...@chromium.org
, Aug 9 2016