New issue
Advanced search Search tips

Issue 634568 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 637174



Sign in to add a comment

Support mojo connections between C++ and Java components in the browser process

Project Member Reported by sa...@chromium.org, Aug 5 2016

Issue description

Currently, interfaces exposed to the renderer can be implemented in Java, but there is no system that allows a C++ component in the browser to use mojo to communicate with a Java component.
 

Comment 1 by sa...@chromium.org, Aug 12 2016

Blockedon: 637174
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13e14e9347cc0ae289c2b339876acea544859675

commit 13e14e9347cc0ae289c2b339876acea544859675
Author: sammc <sammc@chromium.org>
Date: Fri Aug 12 04:21:29 2016

Add a Java InterfaceRegistry.

This also removes the old Java mojo application support, which has
rotted.

BUG= 634568 , 637174 

Review-Url: https://codereview.chromium.org/2214323002
Cr-Commit-Position: refs/heads/master@{#411550}

[modify] https://crrev.com/13e14e9347cc0ae289c2b339876acea544859675/services/shell/public/java/BUILD.gn
[delete] https://crrev.com/2d841fa9cb4c1cd9eb3dfb9329cc7b8119ad94ee/services/shell/public/java/src/org/chromium/mojo/application/ApplicationConnection.java
[delete] https://crrev.com/2d841fa9cb4c1cd9eb3dfb9329cc7b8119ad94ee/services/shell/public/java/src/org/chromium/mojo/application/ApplicationDelegate.java
[delete] https://crrev.com/2d841fa9cb4c1cd9eb3dfb9329cc7b8119ad94ee/services/shell/public/java/src/org/chromium/mojo/application/ApplicationImpl.java
[delete] https://crrev.com/2d841fa9cb4c1cd9eb3dfb9329cc7b8119ad94ee/services/shell/public/java/src/org/chromium/mojo/application/ApplicationRunner.java
[delete] https://crrev.com/2d841fa9cb4c1cd9eb3dfb9329cc7b8119ad94ee/services/shell/public/java/src/org/chromium/mojo/application/ServiceFactoryBinder.java
[delete] https://crrev.com/2d841fa9cb4c1cd9eb3dfb9329cc7b8119ad94ee/services/shell/public/java/src/org/chromium/mojo/application/ShellHelper.java
[add] https://crrev.com/13e14e9347cc0ae289c2b339876acea544859675/services/shell/public/java/src/org/chromium/services/shell/InterfaceFactory.java
[add] https://crrev.com/13e14e9347cc0ae289c2b339876acea544859675/services/shell/public/java/src/org/chromium/services/shell/InterfaceRegistry.java

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b

commit f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b
Author: sammc <sammc@chromium.org>
Date: Tue Sep 20 23:05:11 2016

Add global and per-WebContents java InterfaceRegistries.

BUG= 634568 ,  637174 

Review-Url: https://codereview.chromium.org/2217813003
Cr-Commit-Position: refs/heads/master@{#419886}

[modify] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/browser/BUILD.gn
[add] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/browser/android/java_interfaces_impl.cc
[add] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/browser/android/java_interfaces_impl.h
[modify] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/public/android/BUILD.gn
[add] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[add] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/public/android/java/src/org/chromium/content_public/browser/InterfaceRegistrar.java
[modify] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/public/browser/BUILD.gn
[add] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/public/browser/android/java_interfaces.h
[modify] https://crrev.com/f5f1b0fdf3a73883a2462ad7d2ed7ee5ec70533b/content/public/browser/web_contents.h

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58dcb20da65389d841cd02d9197fb43efb6e8ee2

commit 58dcb20da65389d841cd02d9197fb43efb6e8ee2
Author: sammc <sammc@chromium.org>
Date: Wed Sep 28 00:53:02 2016

Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG= 634568 ,  637174 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2214383002
Cr-Commit-Position: refs/heads/master@{#421403}

[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/android/BUILD.gn
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/android/java/DEPS
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImplementationFactory.java
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/browser/BUILD.gn
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/browser/DEPS
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/browser/android/mojo/chrome_interface_registrar_android.cc
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/browser/android/mojo/chrome_interface_registrar_android.h
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/browser/BUILD.gn
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/browser/DEPS
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/public/android/BUILD.gn
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[add] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/content/public/android/java/src/org/chromium/content/browser/NfcFactory.java
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/device/DEPS
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/device/battery/android/BUILD.gn
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/device/vibration/android/BUILD.gn
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/services/shell/public/cpp/interface_provider.h
[modify] https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2/services/shell/public/java/src/org/chromium/services/shell/InterfaceRegistry.java

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0978dbef2be061ff7a17bcaaf3edbade26dd0af2

commit 0978dbef2be061ff7a17bcaaf3edbade26dd0af2
Author: dtrainor <dtrainor@chromium.org>
Date: Wed Sep 28 21:23:12 2016

Revert of Move registration of Java mojo interfaces to the new InterfaceRegistrar. (patchset #5 id:300001 of https://codereview.chromium.org/2214383002/ )

Reason for revert:
Looks like I have to revert this :(.  Breaking the Chromium Android FYI bot.  Basically Android doesn't actually include or build any native code from device/battery.  It also doesn't depend on and build battery_monitor.mojom for certain targets.  Sorry!

See compile failures here:
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20(dbg)

gn args to reproduce:
enable_vr_shell = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = true
proprietary_codecs = true
symbol_level = 1
target_os = "android"
use_goma = true

build targets to reproduce:
chrome/browser/android/vr_shell
chrome/browser/android/vr_shell:vr_shell_unittests

Original issue's description:
> Move registration of Java mojo interfaces to the new InterfaceRegistrar.
>
> Previously, Java-implemented mojo interfaces were registered on the C++
> InterfaceRegistries via JNI. This CL migrates those registrations to
> dedicated Java InterfaceRegistries that C++ code can access via
> corresponding InterfaceProviders.
>
> BUG= 634568 ,  637174 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
> Cr-Commit-Position: refs/heads/master@{#421403}

TBR=rockot@chromium.org,boliu@chromium.org,jam@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 634568 ,  637174 

Review-Url: https://codereview.chromium.org/2374213002
Cr-Commit-Position: refs/heads/master@{#421642}

[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/android/BUILD.gn
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/android/java/DEPS
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImplementationFactory.java
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/browser/BUILD.gn
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/browser/DEPS
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/browser/android/mojo/chrome_interface_registrar_android.cc
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/browser/android/mojo/chrome_interface_registrar_android.h
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/content/browser/BUILD.gn
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/content/browser/DEPS
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/content/public/android/BUILD.gn
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[delete] https://crrev.com/cc15f8caba4e0d7b339379deb2867325fbe4246f/content/public/android/java/src/org/chromium/content/browser/NfcFactory.java
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/device/DEPS
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/device/battery/android/BUILD.gn
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/device/vibration/android/BUILD.gn
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/services/shell/public/cpp/interface_provider.h
[modify] https://crrev.com/0978dbef2be061ff7a17bcaaf3edbade26dd0af2/services/shell/public/java/src/org/chromium/services/shell/InterfaceRegistry.java

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a139ba8b5636e7196714b4132b9240b18579ed3

commit 5a139ba8b5636e7196714b4132b9240b18579ed3
Author: sammc <sammc@chromium.org>
Date: Thu Sep 29 01:49:14 2016

Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG= 634568 ,  637174 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Review-Url: https://codereview.chromium.org/2214383002
Cr-Original-Commit-Position: refs/heads/master@{#421403}
Cr-Commit-Position: refs/heads/master@{#421711}

[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/android/BUILD.gn
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/android/java/DEPS
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImplementationFactory.java
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/browser/BUILD.gn
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/browser/DEPS
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/browser/android/mojo/chrome_interface_registrar_android.cc
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/browser/android/mojo/chrome_interface_registrar_android.h
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/browser/BUILD.gn
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/browser/DEPS
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/public/android/BUILD.gn
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
[add] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/content/public/android/java/src/org/chromium/content/browser/NfcFactory.java
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/device/DEPS
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/device/battery/android/BUILD.gn
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/device/vibration/android/BUILD.gn
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/services/shell/public/cpp/interface_provider.h
[modify] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/services/shell/public/java/src/org/chromium/services/shell/InterfaceRegistry.java

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ca7f13cfcf3a15a68133a270d04bec769aa2d1

commit 86ca7f13cfcf3a15a68133a270d04bec769aa2d1
Author: sammc <sammc@chromium.org>
Date: Fri Sep 30 02:00:23 2016

Remove the JNI-based InterfaceRegistry.

Java interface registration has been migrated to a Java-implemented
InterfaceRegistry. This CL removes the now unused JNI-based
InterfaceRegistry.

BUG= 634568 , 637174 , 649022 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2217013002
Cr-Commit-Position: refs/heads/master@{#422013}

[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/browser/BUILD.gn
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/browser/android/browser_jni_registrar.cc
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/browser/android/interface_provider_android_impl.cc
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/browser/android/interface_provider_android_impl.h
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/browser/android/interface_registry_android_impl.cc
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/browser/android/interface_registry_android_impl.h
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/browser/frame_host/render_frame_host_impl.h
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/browser/mojo/interface_registrar_android.cc
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/browser/mojo/interface_registrar_android.h
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/public/android/BUILD.gn
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/public/android/java/src/org/chromium/content/browser/InterfaceProvider.java
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/public/android/java/src/org/chromium/content/browser/InterfaceRegistry.java
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/public/android/javatests/src/org/chromium/content/browser/InterfaceRegistryTest.java
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/public/browser/BUILD.gn
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/public/browser/android/interface_provider_android.h
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/public/browser/android/interface_registry_android.h
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/shell/BUILD.gn
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/shell/android/BUILD.gn
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/shell/android/java/src/org/chromium/content_shell/ShellMojoTestUtils.java
[modify] https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1/content/shell/android/shell_jni_registrar.cc
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/shell/browser/shell_mojo_test_utils_android.cc
[delete] https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86/content/shell/browser/shell_mojo_test_utils_android.h

Comment 8 by sa...@chromium.org, Sep 30 2016

Status: Fixed (was: Started)

Sign in to add a comment