New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634567 link

Starred by 3 users
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Nov 2016
Cc:
█ meade@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

variable tests double-include testharness.js

Project Member Reported by geoff...@gmail.com, Aug 5 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/601.7.7 (KHTML, like Gecko) Version/9.1.2 Safari/601.7.7

Example URL:
third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization.html

Steps to reproduce the problem:
1. Open third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization.html or third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization-quirks-mode.html
2. Wait ten seconds
3. Look at the harness timeout

What is the expected behavior?
The harness doesn't timeout

What went wrong?
The harness timed out after running to completion

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? No 

Does this work in other browsers? N/A 

Chrome version: 54.0.2819.0 (Official Build) canary (64-bit)  Channel: n/a
OS Version: OS X 10.11.6
Flash Version: 

This wizard makes no sense for this bug report…

Comment 1 by geoff...@gmail.com, Aug 5 2016 

I've thrown up https://codereview.chromium.org/2215203002/ which addresses this.

Comment 2 by tkent@chromium.org, Aug 5 2016

Components: -Blink Blink>CSS

Comment 3 by rjwright@chromium.org, Aug 5 2016

Owner: shans@chromium.org
Status: Started (was: Unconfirmed)
CL awaiting review.

Comment 4 by dstockwell@chromium.org, Aug 10 2016

Labels: Test-Layout

Comment 5 by shans@chromium.org, Nov 3 2016

Owner: ----
Status: Available (was: Started)

Comment 6 by shans@chromium.org, Nov 3 2016

Cc: meade@chromium.org
Eddy, can you find someone to track this from the Google side?

Also: Geoff: status update please?

Comment 7 by geoff...@gmail.com, Nov 3 2016 

Basic conclusion was that it needs a contractual amendment to avoid the conflict with the CLA, and until such time as I want to do more than occasional, tiny CLs neither me nor rbyers really feel the motivation to get that to happen. As such, should probably just delete than CL and let someone else fix it, if that LGTY?
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/804776f216c2d2747773aa28a7bdb49c39d173c8

commit 804776f216c2d2747773aa28a7bdb49c39d173c8
Author: ericwilligers <ericwilligers@chromium.org>
Date: Wed Nov 30 11:39:58 2016

CSS Variables: Fix double include of testharness.js

Fix the two tests identified by
git grep "/testharness.js" | grep "<script" | cut -d':' -f1 | uniq -d

Problem spotted by geoffers@gmail.com

BUG= 634567 

Review-Url: https://codereview.chromium.org/2538613002
Cr-Commit-Position: refs/heads/master@{#435221}

[modify] https://crrev.com/804776f216c2d2747773aa28a7bdb49c39d173c8/third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization-quirks-mode.html
[modify] https://crrev.com/804776f216c2d2747773aa28a7bdb49c39d173c8/third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization.html

Comment 9 by ericwilligers@chromium.org, Nov 30 2016

Owner: ericwilligers@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment