New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634543 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

SSLUITest.TestUnsafeContentsWithUserException is failing flakily, preventing try jobs from succeeding

Project Member Reported by dbeam@chromium.org, Aug 4 2016

Issue description

Cc: jam@chromium.org
+jam, might be related to some refactoring that he's been doing

Comment 2 by jam@chromium.org, Aug 5 2016

That's me, I'll revert the cl while I investigate.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aae8a212cb79e589dfc7328a6c03138b424a754

commit 7aae8a212cb79e589dfc7328a6c03138b424a754
Author: jam <jam@chromium.org>
Date: Fri Aug 05 00:48:10 2016

Revert of Remove usage of SSLStatus in RenderFrameImpl. (patchset #6 id:140001 of https://codereview.chromium.org/2191113002/ )

Reason for revert:
Causing test flakiness.

BUG= 634543 

Original issue's description:
> Remove usage of SSLStatus in RenderFrameImpl.
>
> Per discussion, this optimization isn't necessary anymore since we don't have a UI that shows frame specific errors.
>
> BUG=598073
>
> Committed: https://crrev.com/6ce51b7351ed32a0b6c82f5a83d83641a1b5babd
> Cr-Commit-Position: refs/heads/master@{#409855}

TBR=estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598073

Review-Url: https://codereview.chromium.org/2214293003
Cr-Commit-Position: refs/heads/master@{#409952}

[modify] https://crrev.com/7aae8a212cb79e589dfc7328a6c03138b424a754/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/7aae8a212cb79e589dfc7328a6c03138b424a754/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/7aae8a212cb79e589dfc7328a6c03138b424a754/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7aae8a212cb79e589dfc7328a6c03138b424a754/testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter

Comment 4 by jam@chromium.org, Aug 5 2016

 Issue 634569  has been merged into this issue.

Comment 5 by jam@chromium.org, Aug 5 2016

 Issue 634531  has been merged into this issue.
Owner: jam@chromium.org
Status: Assigned (was: Unconfirmed)
Mac triage marking assigned to jam@ per #2 :)

Comment 7 by jam@chromium.org, Aug 8 2016

Status: Fixed (was: Assigned)

Sign in to add a comment