The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e03be7f3be92a1940c19aab0664ca02ce1011f

commit d5e03be7f3be92a1940c19aab0664ca02ce1011f
Author: junov <junov@chromium.org>
Date: Wed Aug 24 18:22:13 2016

Add some plumbing for the color management of canvases

This change adds an experimental canvas feature for specifying a
color space at context creation time. This change also adds the
necessary plumbing to propagate the color space information to the
SkSurface objects that back the canvas, as well as the mailboxes and
compositor resources that transport the canvas contents

BUG=634542
TBR=danakj
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2212163002
Cr-Commit-Position: refs/heads/master@{#414108}

[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/cc/resources/resource_provider.cc
[add] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/LayoutTests/fast/canvas/canvas-colorSpace-attribute.html
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/canvas2d/Canvas2DContextAttributes.idl
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[delete] https://crrev.com/7a5d260eaadd7efcc073564b94c5c91e1856110d/third_party/WebKit/Source/modules/canvas2d/ContextAttributeHelpers.cpp
[delete] https://crrev.com/7a5d260eaadd7efcc073564b94c5c91e1856110d/third_party/WebKit/Source/modules/canvas2d/ContextAttributeHelpers.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/Canvas2DImageBufferSurface.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/ImageBuffer.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h
[modify] https://crrev.com/d5e03be7f3be92a1940c19aab0664ca02ce1011f/third_party/WebKit/public/platform/WebExternalBitmap.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75885ebb694faeabc19dd751561a82a582703793

commit 75885ebb694faeabc19dd751561a82a582703793
Author: junov <junov@chromium.org>
Date: Thu Oct 20 19:17:54 2016

Fix the linear-rgb canvas color space so that it renders

This change fixes colorSpace:"linear-rgb" for 2D canvas so that
the skia rendering pipeline actually renders correctly into its
backing.  The results still do not propagate to the display,
but they are inspectable via getImageData.

The main issue was that skia only support linear transfer curves
when the color type is 16-bit float. Also, getImage data had to
work around some output format limitations in skia

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://chromiumcodereview.appspot.com/2425113002
Cr-Commit-Position: refs/heads/master@{#426558}

[add] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-linear-rgb.html
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/Canvas2DImageBufferSurface.h
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.h
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
[modify] https://crrev.com/75885ebb694faeabc19dd751561a82a582703793/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h

 Issue 672299  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50c83740c5e9efd2ffe380b0f0181e843908172b

commit 50c83740c5e9efd2ffe380b0f0181e843908172b
Author: junov <junov@chromium.org>
Date: Wed Dec 14 15:18:05 2016

Add ColorBehavior plumbing for 2D canvas drawImage

BUG=634542

Review-Url: https://codereview.chromium.org/2572873002
Cr-Commit-Position: refs/heads/master@{#438519}

[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp
[modify] https://crrev.com/50c83740c5e9efd2ffe380b0f0181e843908172b/third_party/WebKit/Source/platform/graphics/ColorBehavior.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95e575c95dbae022874c992ac7c87cde406d38a3

commit 95e575c95dbae022874c992ac7c87cde406d38a3
Author: zakerinasab <zakerinasab@chromium.org>
Date: Fri Jan 27 20:31:00 2017

Add rec-2020 and p3 color spaces to canvas

This change adds two new color spaces to canvas: linear-rec-2020 and
linear-p3. It also adds two layout tests that examines if the Skia
rendering pipeline correctly renders the canvases with these color
space tags.

We still do not have end-to-end layout tests for these color spaces
(and also linear-rgb). This issue will be addressed later.

This change also inherits this issue from the previous CL:
"getImage data had to work around some output format limitations in skia."

BUG=634542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2656623002
Cr-Commit-Position: refs/heads/master@{#446751}

[add] https://crrev.com/95e575c95dbae022874c992ac7c87cde406d38a3/third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-p3.html
[add] https://crrev.com/95e575c95dbae022874c992ac7c87cde406d38a3/third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-rec-2020.html
[modify] https://crrev.com/95e575c95dbae022874c992ac7c87cde406d38a3/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-colorSpace-attribute.html
[modify] https://crrev.com/95e575c95dbae022874c992ac7c87cde406d38a3/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl
[modify] https://crrev.com/95e575c95dbae022874c992ac7c87cde406d38a3/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/95e575c95dbae022874c992ac7c87cde406d38a3/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/95e575c95dbae022874c992ac7c87cde406d38a3/third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl
[modify] https://crrev.com/95e575c95dbae022874c992ac7c87cde406d38a3/third_party/WebKit/Source/modules/canvas2d/Canvas2DContextAttributes.idl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d

commit d0b25b0a993e6623ddf9deb789cbd6f9ae35435d
Author: zakerinasab <zakerinasab@chromium.org>
Date: Sat Feb 25 02:46:22 2017

Implement canvas color space IDL format for 2D canvas

This patch updates the previous implementation of the canvas color space
to match the latest changes of the proposal in
https://github.com/WICG/canvas-color-space/blob/master/CanvasColorSpaceProposal.md

BUG=634542

Review-Url: https://codereview.chromium.org/2708403003
Cr-Commit-Position: refs/heads/master@{#453052}

[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/content/test/data/gpu/pixel_canvas_display_linear-rgb.html
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-linear-rgb.html
[rename] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-rec2020.html
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/LayoutTests/fast/canvas/color-space/display_linear-rgb.html
[delete] https://crrev.com/3fffa417af5b70accf1fe290b60de87c419be5df/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-colorSpace-attribute.html
[add] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-colorspace-arguments.html
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[delete] https://crrev.com/3fffa417af5b70accf1fe290b60de87c419be5df/third_party/WebKit/Source/modules/canvas2d/Canvas2DContextAttributes.idl
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
[add] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DSettings.idl
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/d0b25b0a993e6623ddf9deb789cbd6f9ae35435d/third_party/WebKit/Source/modules/modules_idl_files.gni

Do we have any plan to standardize CanvasContextCreationAttributes?

They should be standardized. Right now the algorithm described in https://html.spec.whatwg.org/multipage/scripting.html#2dcontext:canvasrenderingcontext2dsettings for "coercing" the incoming dictionary to CanvasRenderingContext2DSettings doesn't really work.

Some time ago the custom binding code for Canvas.getContext was deleted from Blink, and in the process, it was discovered that all of the dictionaries for all of the canvas context types basically have to be compatible. The spec shouldn't define a per-context type for the second argument to getContext.

This may cause some scalability problems during spec development, since a central document will have to be updated each time one of the canvas context specs adds a new attribute. https://wiki.whatwg.org/wiki/CanvasContexts used to be that central place, but it's now obsolete.

 Issue 678629  has been merged into this issue.