New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634533 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Bisect Jobs redo steps on multiple devices.

Project Member Reported by zxiong@google.com, Aug 4 2016

Issue description

Bisect hosts with multiple test devices will run bisect tests on each of its devices even after one of them succeeded. 

Culprit CL: https://codereview.chromium.org/2119483003/

Example: https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/426

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/ef700964e04ba92356b0d19d6e9aec139718b6b2

commit ef700964e04ba92356b0d19d6e9aec139718b6b2
Author: zxiong <zxiong@google.com>
Date: Fri Aug 05 01:11:33 2016

Break out of for loop if bisect job succeeds on one test device

Currently if a bisect host has multiple test devices, it will
run bisect jobs on all of them. It should stop once one of the
test devices finish running the job successfully.
BUG= chromium:634533 

Review-Url: https://codereview.chromium.org/2216113002

[modify] https://crrev.com/ef700964e04ba92356b0d19d6e9aec139718b6b2/scripts/slave/recipe_modules/auto_bisect/local_bisect.py
[modify] https://crrev.com/ef700964e04ba92356b0d19d6e9aec139718b6b2/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_basic_device.json
[modify] https://crrev.com/ef700964e04ba92356b0d19d6e9aec139718b6b2/scripts/slave/recipes/bisection/android_bisect.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/b2e0fbd3778f4c2a08c03c118685fcc2168f5f8a

commit b2e0fbd3778f4c2a08c03c118685fcc2168f5f8a
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Aug 05 01:26:44 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/ef700964e04ba92356b0d19d6e9aec139718b6b2 Break out of for loop if bisect job succeeds on one test device (zxiong@google.com)

R=zxiong@google.com
BUG= chromium:634533 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2216973002

[modify] https://crrev.com/b2e0fbd3778f4c2a08c03c118685fcc2168f5f8a/infra/config/recipes.cfg

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 5 2016

Project Member

Comment 4 by sheriffbot@chromium.org, Aug 5 2016

Labels: Hotlist-Google

Comment 5 by zxiong@google.com, Aug 5 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment