Emulate ES3 BlitFramebuffer behavior on OpenGL 4.2 or lower |
|||||||
Issue descriptionOpenGL 4.2 (Core Profile) spec, Section 4.3.2 Copying Pixels, BlitFramebuffer: "When values are taken from the read buffer, no linearization is performed even if the format of the buffer is SRGB. When values are written to the draw buffers, blit operations bypass most of the fragment pipeline. The only fragment operations which affect a blit are the pixel ownership test, the scissor test, and sRGB conversion." OpenGL 4.3 (Core Profile) spec, Section 18.3.1 Blitting Pixel Rectangles: "When values are taken from the read buffer, if the value of FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING for the framebuffer attachment corresponding to the read buffer is SRGB (see section 9.2.3), the red, green, and blue components are converted from the non-linear sRGB color space according to equation 8.14. When values are taken from the read buffer, no linearization is performed even if the format of the buffer is SRGB. When values are written to the draw buffers, blit operations bypass most of the fragment pipeline. The only fragment operations which affect a blit are the pixel ownership test, the scissor test, and sRGB conversion (see section 17.3.9)." I think there is a bug in this spec, the second paragraph is copied from earlier spec version and should have been deleted here. OpenGL 4.4 (Core Profile) spec, Section 18.3.1 Blitting Pixel Rectangles: "When values are taken from the read buffer, if FRAMEBUFFER_SRGB is enabled and the value of FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING for the framebuffer attachment corresponding to the read buffer is SRGB (see section 9.2.3), the red, green, and blue components are converted from the non-linear sRGB color space according to equation 8.14. When values are written to the draw buffers, blit operations bypass most of the fragment pipeline. The only fragment operations which affect a blit are the pixel ownership test, the scissor test, and sRGB conversion (see section 17.3.9)."
,
Aug 4 2016
To emulate the ES3 behavior on Desktop 4.4 and above, we only need to enable FRAMEBUFFER_SRGB when source format is sRGB. To emulate the ES3 behavior on Desktop 4.2 or below, if source is sRGB format, and target is sRGB, we will need to use a shader to do the encoding/decoding. 4.3 spec is buggy, so to be on the safe side, we should follow the 4.2 or below code path.
,
Aug 5 2016
I can take a look.
,
Aug 8 2016
There is also the situation when the source is a renderbuffer, so we can not directly draw like the texture case. We have to blit to an intermediate texture first. Then we need to consider if the intermediate texture is encoded as sRGB or not.
,
Aug 16 2016
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16237bb3f01e0088c5a96a7228ed062da81134be commit 16237bb3f01e0088c5a96a7228ed062da81134be Author: yunchao.he <yunchao.he@intel.com> Date: Wed Sep 14 20:27:47 2016 Roll WebGL 6a1c97a..582169b https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6a1c97a..582169b BUG= 634525 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2335113002 Cr-Commit-Position: refs/heads/master@{#418658} [modify] https://crrev.com/16237bb3f01e0088c5a96a7228ed062da81134be/DEPS [modify] https://crrev.com/16237bb3f01e0088c5a96a7228ed062da81134be/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Sep 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd79169d48f8d31025b69c5dc05b7f00994a4f3d commit fd79169d48f8d31025b69c5dc05b7f00994a4f3d Author: yunchao.he <yunchao.he@intel.com> Date: Sun Sep 18 07:27:05 2016 [Command Buffer] emulate SRGB color format for BlitFramebuffer in OpenGL. In Desktop OGLs whose version < 4.4, they maybe don't enable srgb conversion between srgb color format and linear color format. This change can emulate srgb and do the conversion for machines with these OGL profiles. BUG= 634525 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2286593002 Cr-Commit-Position: refs/heads/master@{#419396} [modify] https://crrev.com/fd79169d48f8d31025b69c5dc05b7f00994a4f3d/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/fd79169d48f8d31025b69c5dc05b7f00994a4f3d/gpu/command_buffer/service/BUILD.gn [modify] https://crrev.com/fd79169d48f8d31025b69c5dc05b7f00994a4f3d/gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc [modify] https://crrev.com/fd79169d48f8d31025b69c5dc05b7f00994a4f3d/gpu/command_buffer/service/gles2_cmd_decoder.cc [add] https://crrev.com/fd79169d48f8d31025b69c5dc05b7f00994a4f3d/gpu/command_buffer/service/gles2_cmd_srgb_converter.cc [add] https://crrev.com/fd79169d48f8d31025b69c5dc05b7f00994a4f3d/gpu/command_buffer/service/gles2_cmd_srgb_converter.h
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4fce8071404a4c5918f6a3a4850694d3169b643 commit c4fce8071404a4c5918f6a3a4850694d3169b643 Author: cwallez <cwallez@chromium.org> Date: Mon Sep 19 21:39:40 2016 BlitFramebuffer: update webgl2 expectations for linux intel for blitframebuffer related tests BUG= 634525 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel patch from issue 2354483002 at patchset 1 (http://crrev.com/2354483002#ps1) Review-Url: https://codereview.chromium.org/2354693002 Cr-Commit-Position: refs/heads/master@{#419566} [modify] https://crrev.com/c4fce8071404a4c5918f6a3a4850694d3169b643/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa1fae069018c6a9f0410a8259ee73d9d5ab0e84 commit aa1fae069018c6a9f0410a8259ee73d9d5ab0e84 Author: cwallez <cwallez@chromium.org> Date: Wed Sep 21 00:39:12 2016 WebGL CTS: add back expectations for blitframebuffer srgb The expectations were eagerly removed because the test passed on Linux Intel, but it still doesn't pass on Linux AMD and Linux Intel ANGLE TBR=zmo@chromium.org BUG= 634525 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2356773002 Cr-Commit-Position: refs/heads/master@{#419920} [modify] https://crrev.com/aa1fae069018c6a9f0410a8259ee73d9d5ab0e84/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab commit 6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab Author: yunchao.he <yunchao.he@intel.com> Date: Wed Sep 21 07:42:40 2016 [Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb image to single-sampled srgb image. Per our discussion with @piman and @kbr at https://codereview.chromium.org/2286593002/, The current code is correct, no further work to be done. Simply remove this TODO is OK. BUG= 634525 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2356813002 Cr-Commit-Position: refs/heads/master@{#420001} [modify] https://crrev.com/6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Sep 22 2016
I'm looking at implementing the same logic in ANGLE but I think it could be simpler to do the following for a blit from FBO1 to FBO2: 1 - Get a texture T in the same format as FBO1, either getting the attachment if it is a texture, or using CopyTexImage if it isn't 2 - Use T to draw to FBO2. From the specification, the sampling of T in step 2) should do the SRGB decode and filtering, and the per-pixel operations should do the SRGB encode to FBO2. Am I missing a detail that would prevent it from working?
,
Sep 22 2016
One thing is that I thought CopyTexImage does not allow reading from multisampled read buffer, the same as ReadPixels. However, now I went through ES3 spec, I can't find some text to support that.
,
Sep 22 2016
@#11: with non-1:1 mapping from source to destination (i.e. scaling), we have to be careful to correctly implement the CLAMP_TO_EDGE behavior on a sub-region of the source. It can be done in the shader, but is non-trivial, in particular with GL_LINEAR filtering. But what you propose is ok if the source rect is the entire image. @#12: CopyTexImage indeed doesn't allow reading from a MS buffer: Towards the end of the "3.8.5 Alternate Texture Image Specification Commands" section, right before "Texture Copying Feedback Loops": "Calling CopyTexSubImage3D, CopyTexImage2D, or CopyTexSubImage2D will result in an INVALID_OPERATION error if any of the following conditions is true: • internalformat of the texel array being (re)specified is RGB9_E5, or • READ_BUFFER is NONE, or • the GL is using a framebuffer object (i.e. READ_FRAMEBUFFER_BINDING is non-zero) and – the read buffer selects an attachment that has no image attached or – the value of SAMPLE_BUFFERS for the read framebuffer is one." Either way, glBlitFramebuffer with a MS source is only allowed when there is no scaling, at which point glBlitFramebuffer on sRGB is as good as we're going to get (we would have to call it to resolve the MS anyway).
,
Sep 22 2016
Thanks, I think I will go forward with doing the clamping in the shader.
,
Sep 22 2016
@cwallez, I add a TODO about sampling from texture directly. Basically, I agree with @piman. If you sample from a texture directly (The read buffer is a texture), you need to handle these two situations carefully to set correct texture coordinate： 1. the src region is only a part of the read buffer. 2. some parts of the src region is outside the read buffer, and the filter is gl.LINEAR (You need to CLAMP_TO_EDGE).
,
Sep 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/123afb9598205d150fdb8b91cd1d8152393514f2 commit 123afb9598205d150fdb8b91cd1d8152393514f2 Author: yunchao.he <yunchao.he@intel.com> Date: Sat Sep 24 00:14:50 2016 [Command buffer] blitFramebuffer should not disable scissor test BUG= 634525 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2362163003 Cr-Commit-Position: refs/heads/master@{#420797} [modify] https://crrev.com/123afb9598205d150fdb8b91cd1d8152393514f2/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/123afb9598205d150fdb8b91cd1d8152393514f2/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc [modify] https://crrev.com/123afb9598205d150fdb8b91cd1d8152393514f2/gpu/command_buffer/service/gles2_cmd_srgb_converter.cc [modify] https://crrev.com/123afb9598205d150fdb8b91cd1d8152393514f2/gpu/command_buffer/service/gles2_cmd_srgb_converter.h
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a commit 26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Sep 27 15:45:42 2016 GL: Emulate SRGB blits where needed. Desktop OpenGL before 4.4 doesn't handle SRGB blits the same way OpenGL ES does. Emulate them by drawing a quad. BUG=angleproject:1492 BUG= chromium:634525 Change-Id: I9f2992d9b373941b10f19f8a51564f0f756cc4df Reviewed-on: https://chromium-review.googlesource.com/389853 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/FramebufferGL.h [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/ContextGL.cpp [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/BlitGL.h [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.h [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/egl/ozone/DisplayOzone.cpp [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/SurfaceGL.cpp [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/FramebufferGL.cpp [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/wgl/DXGISwapChainWindowSurfaceWGL.h [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/wgl/DXGISwapChainWindowSurfaceWGL.cpp [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.h [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/common/mathutil.h [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/cgl/PbufferSurfaceCGL.mm [modify] https://crrev.com/26a717b0f390c27ddd6ee8dff7eb2ad92bafd55a/src/libANGLE/renderer/gl/BlitGL.cpp
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9859aac71e6b077f66c37da16896971a81c02e08 commit 9859aac71e6b077f66c37da16896971a81c02e08 Author: jmadill <jmadill@chromium.org> Date: Thu Oct 06 20:11:14 2016 Roll ANGLE d08f3b3..873d00f https://chromium.googlesource.com/angle/angle.git/+log/d08f3b3..873d00f BUG= chromium:653274 , chromium:651493 , chromium:653276 , chromium:593024 , chromium:634525 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2399933002 Cr-Commit-Position: refs/heads/master@{#423643} [modify] https://crrev.com/9859aac71e6b077f66c37da16896971a81c02e08/DEPS
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e74eb9a9ec27745621b6396b94f56c1a8e3c36a commit 9e74eb9a9ec27745621b6396b94f56c1a8e3c36a Author: cwallez <cwallez@chromium.org> Date: Thu Oct 06 20:53:42 2016 WebGL CTS: remove fixed Linux Intel ANGLE expectations TBR=zmo@chromium.org BUG=angleproject:1492 BUG= chromium:634525 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2397213002 Cr-Commit-Position: refs/heads/master@{#423669} [modify] https://crrev.com/9e74eb9a9ec27745621b6396b94f56c1a8e3c36a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Oct 8 2016
This work is done. There are still some failures in framebufferblit/ under deqp/ in WebGL 2 CTS. But they are not caused by srgb emulation issue. I will mark it as fixed and close this issue. Please re-open this issue if necessary.
,
Oct 8 2016
,
Oct 10 2016
Thank you Yunchao for your careful and thorough work on this issue!
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc7b5b184d066e8a31ed0b8460a49ef059742311 commit dc7b5b184d066e8a31ed0b8460a49ef059742311 Author: cwallez <cwallez@chromium.org> Date: Tue Oct 11 15:45:04 2016 Revert of WebGL CTS: remove fixed Linux Intel ANGLE expectations (patchset #1 id:1 of https://codereview.chromium.org/2397213002/ ) Reason for revert: For some reason the ANGLE side workaround doesn't work on the bots? Original issue's description: > WebGL CTS: remove fixed Linux Intel ANGLE expectations > > TBR=zmo@chromium.org > BUG=angleproject:1492 > BUG= chromium:634525 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Committed: https://crrev.com/9e74eb9a9ec27745621b6396b94f56c1a8e3c36a > Cr-Commit-Position: refs/heads/master@{#423669} TBR=zmo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=angleproject:1492 Review-Url: https://codereview.chromium.org/2406313002 Cr-Commit-Position: refs/heads/master@{#424438} [modify] https://crrev.com/dc7b5b184d066e8a31ed0b8460a49ef059742311/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Oct 11 2016
That's unfortunate. Do we need to update the drivers or something similar on the bots?
,
Oct 11 2016
Not sure yet, I'll investigate a bit later this week.
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3ef4848b1a9eef89def84560448821285acb5ae commit b3ef4848b1a9eef89def84560448821285acb5ae Author: yunchao.he <yunchao.he@intel.com> Date: Tue Oct 18 15:31:17 2016 Use high precision texture format during srgb conversion emulation for blitFramebuffer BUG= 634525 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2419153003 Cr-Commit-Position: refs/heads/master@{#425968} [modify] https://crrev.com/b3ef4848b1a9eef89def84560448821285acb5ae/gpu/command_buffer/service/gles2_cmd_srgb_converter.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9859aac71e6b077f66c37da16896971a81c02e08 commit 9859aac71e6b077f66c37da16896971a81c02e08 Author: jmadill <jmadill@chromium.org> Date: Thu Oct 06 20:11:14 2016 Roll ANGLE d08f3b3..873d00f https://chromium.googlesource.com/angle/angle.git/+log/d08f3b3..873d00f BUG= chromium:653274 , chromium:651493 , chromium:653276 , chromium:593024 , chromium:634525 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2399933002 Cr-Commit-Position: refs/heads/master@{#423643} [modify] https://crrev.com/9859aac71e6b077f66c37da16896971a81c02e08/DEPS
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e74eb9a9ec27745621b6396b94f56c1a8e3c36a commit 9e74eb9a9ec27745621b6396b94f56c1a8e3c36a Author: cwallez <cwallez@chromium.org> Date: Thu Oct 06 20:53:42 2016 WebGL CTS: remove fixed Linux Intel ANGLE expectations TBR=zmo@chromium.org BUG=angleproject:1492 BUG= chromium:634525 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2397213002 Cr-Commit-Position: refs/heads/master@{#423669} [modify] https://crrev.com/9e74eb9a9ec27745621b6396b94f56c1a8e3c36a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c22bae95d9d3afc83ab83faec39227a09fe47fda commit c22bae95d9d3afc83ab83faec39227a09fe47fda Author: cwallez <cwallez@chromium.org> Date: Mon Nov 14 19:14:39 2016 WebGL CTS: remove now passing expectations. Most of them come from implementing a work around for blits on Intel. BUG= chromium:483282 BUG= chromium:598902 BUG= chromium:634525 BUG= chromium:655147 BUG= chromium:658898 BUG= chromium:658832 BUG= chromium:664180 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2501543003 Cr-Commit-Position: refs/heads/master@{#431891} [modify] https://crrev.com/c22bae95d9d3afc83ab83faec39227a09fe47fda/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Jun 20 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by zmo@chromium.org
, Aug 4 2016