New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634520 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
machenb...@chromium.org
dpranke@chromium.org
mar...@chromium.org
█ brettw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

GN Doc: 'copy' action does not mention 'data' field(?) necessary for isolate_test

Project Member Reported by js...@chromium.org, Aug 4 2016 
The section on 'copy' at https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md does not mention 'data'. 

When 'outputs' are necessary at runtime (e.g. ICU data bundle), they need to be separately listed in 'data' field. Otherwise, trybot's isolate_tests step wouldn't copy 'outputs' to slave bots from a builder. 

https://codereview.chromium.org/2197523002 is an example where 'data' is necessary.

Comment 1 by mar...@chromium.org, Aug 5 2016

Cc: dpranke@chromium.org
Labels: Build-Tools-GN
Thanks, I've observed this too. There's also an issue where too many files are mapped in, so more work in this will be needed once the dust settles to cleanup both GN behavior and our BUILD.gn files so the strict minimal subset is always correctly mapped in. It's a significant effort so just focusing on removing the copy-pasting, like I did at https://codereview.chromium.org/2202393002/diff/240001/chrome/browser/resources/chromeos/chromevox/BUILD.gn is a good start to clean up BUILD.gn files.
►

Sign in to add a comment