New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634516 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

App crashes when we press and hold “No Thanks” in Bookmark screen

Project Member Reported by vkarut...@chromium.org, Aug 4 2016

Issue description

App Version: 53.2785.43 beta
iOS Version: 9.3.3
Device: iPad, iPhone 

Prerequisite:
Do not sign-in to Chrome

Steps to reproduce:
  1. Install and Launch Chrome
  2. Open any webpage (google.com)
  3. Open Bookmarks window (Settings->Bookmarks)
  4. Press and hold the “No Thanks” button

Observed results:
App crashes  
https://crash.corp.google.com/browse?stbtiq=43918ac200000000

Expected results:
App should not crash 

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): No
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M53

Link to video/image:
https://drive.google.com/open?id=0B-tbaGTQZtpQWlg0bVg0X293ZDQ
 
Cc: lpromero@chromium.org
Labels: ReleaseBlock-Stable M-53
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
Cc: pinkerton@chromium.org
Labels: -Pri-2 Pri-1
Labels: -Restrict-View-Google
Status: Started (was: Assigned)
Super interesting. Can't reproduce on ToT, but can on dev build. Checking out M53 branch to see if it reproduces there.
Can't reproduce on branch either, at least on simulator. Will try with a device once I get to the office.
Status: WontFix (was: Started)
Can't reproduce on latest dev build. 
Status: Assigned (was: WontFix)
This issue is still reproduced on iPhone6s and iPad pro (9.7 inch).
Same steps as originally reported. 
Build: 55.0.2866.0 canary

Please let us know if you need any other information.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/552dc46407fbf7fe4afdb80d95ab07d92cb77007

commit 552dc46407fbf7fe4afdb80d95ab07d92cb77007
Author: stkhapugin <stkhapugin@google.com>
Date: Thu Sep 22 16:38:19 2016

Labels: -M-53 M-54 Merge-Request-54
Status: Fixed (was: Assigned)

Comment 10 by dimu@chromium.org, Sep 23 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before AppStore submit on M54, manual review required.
Tested in 55.0.2869.0 dev, iPad air2 iOS9.3.5 - Fix looks good
Labels: -Hotlist-Merge-review -Merge-Review-54 Merge-Approved-54
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 27 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Verified (was: Fixed)
No crashes observed.
Verified on Device: iPhone6s, iPad pro
iOS: 10.1, 9.3.5
Build: M55.0.2873.0 canary
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 1 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 3 2016

Labels: -merge-approved-54 Merge-Merged-2840
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d42a2e3b14b91eb0e7b477aba010b6c569bd9d71

commit d42a2e3b14b91eb0e7b477aba010b6c569bd9d71
Author: stkhapugin <stkhapugin@google.com>
Date: Thu Sep 22 16:38:19 2016

Verified on latest chrome beta version 54.0.2840.50 on iPhone 6s plus with iOS 10.0.2, iPad Pro with iOS 9.3.5, iPhone 6s with iOS 9.3.5 following the steps mentioned in comment #0.  No crashes observed.  Looks good.

Sign in to add a comment