Fullscreen windows are not restored properly when leaving overview mode |
||||||||
Issue description(1) open chrome calculator app (2) press F4 to make it fullscreen (3) press F5 to enter overview mode (4) click on calculator app notice that app is not restored to its fullscreen size but left at the smaller transformed size used in overview mode.
,
Aug 4 2016
Could not repro this in M-53, while issue 631956 is no a recent regression, so likely very different after all. Will need to bisect. Can repro it with ToT (54.0.2818.0) both with MD flags on and off so not something specific to MD overview code path.
,
Aug 5 2016
Bisect points to https://codereview.chromium.org/2185773002 (r408507). oshima@, could hariank@ take a look (could not assign directly without a chromium account)?
,
Aug 5 2016
Issue 634901 has been merged into this issue.
,
Aug 5 2016
hariank@, can you look into this?
,
Aug 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52d3a47c75a47c5e8b1e424d53b48401cd50dbdd commit 52d3a47c75a47c5e8b1e424d53b48401cd50dbdd Author: hariank <hariank@google.com> Date: Mon Aug 08 18:04:50 2016 Correctly restore fullscreen window bounds when leaving overview mode. In WindowSelector's OnDisplayMetricsChanged, reposition windows only if a metric other than the work area is changed. BUG= 634489 Review-Url: https://codereview.chromium.org/2225523002 Cr-Commit-Position: refs/heads/master@{#410393} [modify] https://crrev.com/52d3a47c75a47c5e8b1e424d53b48401cd50dbdd/ash/common/wm/overview/window_selector.cc
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1280a8d37f97c49f121a6628a3b7543add3a68c commit e1280a8d37f97c49f121a6628a3b7543add3a68c Author: varkha <varkha@chromium.org> Date: Tue Aug 09 13:18:15 2016 [ash-md] Prevents auto-positioning after cancelling overview This fixes the bug differently. Rother than disabling the auto-positioning for specific types of display metrics changes it is disabled for any display metrics changes but only after Shutdown has been called. Consider a situation when display metrics change while overview mode is active - it should respond by auto-positioning windows. BUG= 634489 Review-Url: https://codereview.chromium.org/2225683005 Cr-Commit-Position: refs/heads/master@{#410648} [modify] https://crrev.com/e1280a8d37f97c49f121a6628a3b7543add3a68c/ash/common/wm/overview/window_selector.cc
,
Aug 29 2016
Valery / hariank@, is there still work to be done here or can this be marked as Fixed?
,
Aug 29 2016
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/484a26851e69dafcc58c7fdf9763c600b8e4ee6a commit 484a26851e69dafcc58c7fdf9763c600b8e4ee6a Author: Mitsuru Oshima <oshima@chromium.org> Date: Tue Sep 13 00:27:10 2016 Correctly restore fullscreen window bounds when leaving overview mode. In WindowSelector's OnDisplayMetricsChanged, reposition windows only if a metric other than the work area is changed. BUG= 634489 Review-Url: https://codereview.chromium.org/2225523002 Cr-Commit-Position: refs/heads/master@{#410393} (cherry picked from commit 52d3a47c75a47c5e8b1e424d53b48401cd50dbdd) Review URL: https://codereview.chromium.org/2338603002 . Cr-Commit-Position: refs/branch-heads/2785@{#880} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/484a26851e69dafcc58c7fdf9763c600b8e4ee6a/ash/common/wm/overview/window_selector.cc
,
Sep 13 2016
oshima@, Does it make sense to merge the fix from #7?
,
Sep 28 2016
verified on 54.0.2840.42 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by varkha@chromium.org
, Aug 4 2016