New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634475 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14.8%-44.2% regression in blink_perf.canvas at 409219:409324

Project Member Reported by sullivan@chromium.org, Aug 4 2016

Issue description

See the link to graphs below.
 
Cc: junov@chromium.org
Owner: junov@chromium.org

=== Auto-CCing suspected CL author junov@chromium.org ===

Hi junov@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Fixing regression in putImageData blink perf test
Author  : junov
Commit description:
  
Creating the image data object by using createImageData instead of
getImageData to avoid state changes that interfere with the
benchmark's execution.  Also doing a drive-by code simplification

BUG= 630670 

Review-Url: https://codereview.chromium.org/2190523003
Cr-Commit-Position: refs/heads/master@{#409263}
Commit  : c3a213e577d12c648fce456d2e0098fe36194abd
Date    : Tue Aug 02 19:12:45 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@409260  457.465  2.78402   5  good
chromium@409262  459.199  0.843902  5  good
chromium@409263  377.857  15.7892   5  bad    <--
chromium@409265  382.681  12.4616   5  bad
chromium@409270  385.974  9.64917   5  bad
chromium@409280  387.519  6.80375   5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 634475

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.canvas
Test Metric: putImageData/putImageData
Relative Change: 15.29%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2271
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005226258416531584


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5830314702667776

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: Performance-Sheriff
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 16 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@409255  117.593  53.7818  18  good
chromium@409324  124.486  13.2234  18  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 634475

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.canvas
Test Metric: putImageData/putImageData
Relative Change: 10.01%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/526
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004136114161433456


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5826986321117184

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 7 by junov@chromium.org, Sep 13 2016

Status: WontFix (was: Assigned)
Regression is due to a change to the test.

Sign in to add a comment