New issue
Advanced search Search tips

Issue 634466 link

Starred by 2 users
Status: Fixed
Owner:
ehmaldonado@chromium.org
Closed: Aug 2016
Cc:
niklase@chromium.org
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Include changelog in script-generated roll CLs of WebRTC in Chromium

Project Member Reported by kjellander@chromium.org, Aug 4 2016 
Some other projects like chromite and Skia includes the git log in the commit message for  their roll CLs for Chromium DEPS. It's pretty nice to have when looking for offending CLs. 
We have a Gitiles link today, but it wouldn't hurt to have the commits in a short summary right in the commit message as well

Our script for rolls is located at
https://cs.chromium.org/chromium/src/tools/roll_webrtc.py

Example: https://chromium.googlesource.com/chromium/src.git/+/2a6c585c5a6ae79954208952a5e03763332dbf8d

See this as low-prio, but it wouldn't hurt if Edward was familiar with our roll script for the future.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09deeb015e05d59a4b6673250f66b8ed172c1065

commit 09deeb015e05d59a4b6673250f66b8ed172c1065
Author: ehmaldonado <ehmaldonado@chromium.org>
Date: Fri Aug 05 13:32:00 2016

Include changelog in script-generated roll CLs of WebRTC in Chromium

It's useful to have when looking for offending CLs.

Example (third_party/chromite):
https://chromium.googlesource.com/chromium/src.git/+/2a6c585c5a6ae79954208952a5e03763332dbf8d

Example (generated by tools/roll_webrtc.py after this CL):
https://codereview.chromium.org/2221453002/

BUG= 634466 

Review-Url: https://codereview.chromium.org/2214373003
Cr-Commit-Position: refs/heads/master@{#410045}

[modify] https://crrev.com/09deeb015e05d59a4b6673250f66b8ed172c1065/tools/roll_webrtc.py

Comment 2 by ehmaldonado@chromium.org, Aug 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment