Various startup metrics (e.g. Startup.BrowserMessageLoopStartTimeMainEntry) have weird "< 7 minutes system startup" logic |
|||
Issue descriptionVarious startup metrics (e.g. Startup.BrowserMessageLoopStartTimeMainEntry) have weird "< 7 minutes system startup" logic. This makes them hard to compare to other metrics that _don't_ have this logic. Suggestion: Remove this bit of logic so that the startup metrics are made consistent. fdoray@, would you mind doing this clean up? Thanks!
,
Aug 9 2016
Targeting M55 when fdoray gets back.
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a804c57f2814605540ef11db5187fb94cf359d8 commit 0a804c57f2814605540ef11db5187fb94cf359d8 Author: fdoray <fdoray@chromium.org> Date: Tue Aug 23 15:50:24 2016 Remove "< 7 minutes system startup" from startup metrics. Record these histograms all the time instead of only after 7 minutes of OS uptime: - Startup.LoadTime.ExeMainToDllMain - Startup.LoadTime.ProcessCreateToDllMain - Startup.LoadTime.ProcessCreateToExeMain - Startup.BrowserMessageLoopStartTimeFromMainEntry - Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun Note: A version of these histograms recorded after 7 minutes of OS uptime is kept for now to allow regressions to be caught reliably. BUG= 634408 Review-Url: https://codereview.chromium.org/2223183002 Cr-Commit-Position: refs/heads/master@{#413746} [modify] https://crrev.com/0a804c57f2814605540ef11db5187fb94cf359d8/components/startup_metric_utils/browser/startup_metric_utils.cc [modify] https://crrev.com/0a804c57f2814605540ef11db5187fb94cf359d8/tools/metrics/histograms/histograms.xml
,
Aug 24 2016
,
Dec 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62f7d4ca915fbad122d81109806e2409bd383a31 commit 62f7d4ca915fbad122d81109806e2409bd383a31 Author: palar <palar@yandex-team.ru> Date: Sat Dec 17 14:18:21 2016 Remove startup metrics recorded 7 minutes after system start. Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG= 634408 R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org Review-Url: https://codereview.chromium.org/2576983003 Cr-Commit-Position: refs/heads/master@{#439343} [modify] https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31/components/startup_metric_utils/browser/startup_metric_utils.cc [modify] https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31/tools/metrics/histograms/histograms.xml |
|||
►
Sign in to add a comment |
|||
Comment 1 by fdoray@chromium.org
, Aug 8 2016