New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634402 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.4% regression in system_health.memory_desktop at 409255:409337

Project Member Reported by petrcermak@chromium.org, Aug 4 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=634402

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg5prUoAkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-hdd

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N  Good?
chromium@409254  25762087  109227   4  good
chromium@409337  27155637  528145   3  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 634402

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:gpu:effective_size_avg/load_games_spychase
Relative Change: 5.41%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/708
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9005184401222187280


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5910899831865344

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/719
Failure reason: the build has failed due to infrastructure failure.

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/719
Failure reason: the build has failed due to infrastructure failure.


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N  Good?
chromium@409254  25816700  0.0      3  good
chromium@409337  27360437  126124   3  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 634402

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:gpu:effective_size_avg/load_games_spychase
Relative Change: 5.84%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/722
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004866069886999920


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5796374763798528

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Aug 10 2016

Mergedinto: 633843
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Raster display item lists via a visual rect RTree.
Author  : wkorman
Commit description:
  
Rather than caching and playing back an entire SkPicture
when rastering a display item list for a particular
playback rect, instead retain display items and query
them via an RTree of their visual rects to find and
raster only what's needed.

Display item lists no longer support the notion of a
bounding "layer rect" with mutable origin.

DisplayItemListSettings proto is obsolete after this
change as it's comprised solely of one field to allow
switching whether to use the aforementioned now-deleted
cached SkPicture code path. It will be deleted in a
subsequent patch.

BUG= 529938 
TBR=sadrul
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/1484163002
Cr-Commit-Position: refs/heads/master@{#409291}
Commit  : ccb9e13712b1632b889960d1d85d556c0139fd51
Date    : Tue Aug 02 20:08:52 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N  Good?
chromium@409254  25562748  374858   5  good
chromium@409275  25606439  294672   5  good
chromium@409286  25693820  274768   5  good
chromium@409289  25738057  212698   5  good
chromium@409290  25816700  0.0      5  good
chromium@409291  27179303  341552   5  bad    <--
chromium@409296  27231185  326169   5  bad
chromium@409337  27310375  315212   5  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 634402

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop
Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:gpu:effective_size_avg/load_games_spychase
Relative Change: 6.84%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/725
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004804842519728560


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5811884360466432

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff

Sign in to add a comment