Certain tests in ASan cause an illegal Wait() |
||
Issue descriptione.g. PopupBlockerBrowserTest.BlockWebContentsCreationIncognito https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/204247/steps/browser_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/PopupBlockerBrowserTest.BlockWebContentsCreationIncognito BookmarkBubbleSignInDelegateTest.OnSignInLinkClickedIncognito https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/204021/steps/browser_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/BookmarkBubbleSignInDelegateTest.OnSignInLinkClickedIncognito ChromeTracingDelegateBrowserTest.ExistingIncognitoSessionBlockingTraceStart https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/204085/steps/browser_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/ChromeTracingDelegateBrowserTest.ExistingIncognitoSessionBlockingTraceStart BrowserNavigatorTest.Disposition_Incognito https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/204030/steps/browser_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/BrowserNavigatorTest.Disposition_Incognito Example stack trace: [24796:24796:0804/100524:FATAL:thread_restrictions.cc(76)] Waiting is not allowed to be used on this thread to prevent jank and deadlock. #0 0x000000645a11 __interceptor_backtrace #1 0x0000075bece3 base::debug::StackTrace::StackTrace() #2 0x00000760ab9c logging::LogMessage::~LogMessage() #3 0x00000770dd2d base::ThreadRestrictions::AssertWaitAllowed() #4 0x0000076d5edd base::WaitableEvent::TimedWait() #5 0x0000076d5d0e base::WaitableEvent::Wait() #6 0x000005f21326 shell::ChildProcessHost::Join() #7 0x000005f23876 shell::OutOfProcessNativeRunner::~OutOfProcessNativeRunner() #8 0x0000041b8f73 shell::ServiceManager::Instance::~Instance() #9 0x0000041b95ae shell::ServiceManager::Instance::~Instance() #10 0x0000041a88c4 shell::ServiceManager::OnInstanceError() #11 0x0000041a7d13 shell::ServiceManager::~ServiceManager() #12 0x0000041a8b0e shell::ServiceManager::~ServiceManager() #13 0x00000357cdc6 content::MojoShellContext::~MojoShellContext() #14 0x000002ef1583 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #15 0x000002ef9e2b content::BrowserMainRunnerImpl::Shutdown() #16 0x000002ee4814 content::BrowserMain() #17 0x00000735e620 content::RunNamedProcessTypeMain() #18 0x000007360333 content::ContentMainRunnerImpl::Run() #19 0x00000735c1fb content::ContentMain() #20 0x0000086c7762 content::BrowserTestBase::SetUp() #21 0x0000077f8982 InProcessBrowserTest::SetUp() #22 0x000009c15ca7 testing::Test::Run() #23 0x000009c17809 testing::TestInfo::Run() #24 0x000009c18a63 testing::TestCase::Run() #25 0x000009c2b066 testing::internal::UnitTestImpl::RunAllTests() #26 0x000009c2a6ca testing::UnitTest::Run() #27 0x00000781e0df base::TestSuite::Run() #28 0x000007597cea ChromeTestSuiteRunner::RunTestSuite() #29 0x00000877e77e content::LaunchTests() #30 0x000007592189 main #31 0x7f25bb2fa7ed __libc_start_main #32 0x000000601f51 <unknown>
,
Aug 4 2016
Issue 634212 has been merged into this issue.
,
Aug 4 2016
Issue 634182 has been merged into this issue.
,
Aug 4 2016
Looks like there was trouble landing the CL to disable the tests. Fix for this flake is in the CQ now: https://codereview.chromium.org/2211203002
,
Aug 4 2016
Issue 634438 has been merged into this issue.
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3403dd79ccf777ef4b9c92ea11bd39b61af83bcb commit 3403dd79ccf777ef4b9c92ea11bd39b61af83bcb Author: rockot <rockot@chromium.org> Date: Thu Aug 04 21:26:40 2016 Cancel ServiceManager connection requests if source Instance dies Prevents orphaned services from unintentionally triggering a restart of the service instance which created them. This resolves flaky behavior wherein a renderer attempts to connect to the browser after its BrowserContext service was shut down. BUG= 634392 R=ben@chromium.org Review-Url: https://codereview.chromium.org/2211203002 Cr-Commit-Position: refs/heads/master@{#409904} [modify] https://crrev.com/3403dd79ccf777ef4b9c92ea11bd39b61af83bcb/services/shell/service_manager.cc [modify] https://crrev.com/3403dd79ccf777ef4b9c92ea11bd39b61af83bcb/services/shell/service_manager.h
,
Aug 4 2016
Bots should go green - I'll keep an eye on them and close them if/when they do
,
Aug 4 2016
close this*
,
Aug 4 2016
These failures appear to be gone
,
Aug 4 2016
Thanks so much for the quick turnaround on this!! |
||
►
Sign in to add a comment |
||
Comment 1 by aboxhall@chromium.org
, Aug 4 2016