WebApkService tests disabled |
||||
Issue descriptionThe tests testApiFailsIfNoPermission, testApiFailsIfHasPermission are both disabled in https://codereview.chromium.org/2182133004/ They should be re-enabled when https://codereview.chromium.org/2182303002/ goes in. This issue is caused by the fact that these tests bind to a new service. This new service gets a classloader that does NOT have the apk_under_test.dex, only the test_apk.dex. However, some classes the new service relies on exist only in the apk_under_test.dex, and so they break. Once we are merging the test_apk and the apk_under_test dex files, we will be okay, since it won't have to try and resolve for a class in apk_under_test.dex
,
Aug 5 2016
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2db0238573cd2cbdaa858d8e51a55baa589df6e6 commit 2db0238573cd2cbdaa858d8e51a55baa589df6e6 Author: pkotwicz <pkotwicz@chromium.org> Date: Tue Aug 16 18:07:51 2016 Re-enable WebApkServiceImplTest This CL moves the TestWebApkServiceImplWrapper service out of chrome_public_test_apk and into a new APK - apk_with_webapk_service. TestWebApkServiceImplWrapper is launched by the test via Context#bindService(). Due to the super-special-instrumentation-test-ClassLoader a ClassNotFoundException was being thrown for IWebApkApi.Stub in TestWebApkServiceImplWrapper#onBind(). apk_with_webapk_service does not use a super-special-ClassLoader. BUG= 634390 TEST=WebApkServiceImplTest.* NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2225683002 Cr-Commit-Position: refs/heads/master@{#412292} [modify] https://crrev.com/2db0238573cd2cbdaa858d8e51a55baa589df6e6/chrome/android/BUILD.gn [modify] https://crrev.com/2db0238573cd2cbdaa858d8e51a55baa589df6e6/chrome/android/javatests/AndroidManifest.xml [modify] https://crrev.com/2db0238573cd2cbdaa858d8e51a55baa589df6e6/chrome/android/webapk/libs/runtime_library/javatests/DEPS [add] https://crrev.com/2db0238573cd2cbdaa858d8e51a55baa589df6e6/chrome/android/webapk/libs/runtime_library/javatests/apk_with_webapk_service/AndroidManifest.xml [add] https://crrev.com/2db0238573cd2cbdaa858d8e51a55baa589df6e6/chrome/android/webapk/libs/runtime_library/javatests/apk_with_webapk_service/BUILD.gn [rename] https://crrev.com/2db0238573cd2cbdaa858d8e51a55baa589df6e6/chrome/android/webapk/libs/runtime_library/javatests/apk_with_webapk_service/src/org/chromium/webapk/lib/runtime_library/test/TestWebApkServiceImplWrapper.java [modify] https://crrev.com/2db0238573cd2cbdaa858d8e51a55baa589df6e6/chrome/android/webapk/libs/runtime_library/javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java [modify] https://crrev.com/2db0238573cd2cbdaa858d8e51a55baa589df6e6/chrome/test/android/BUILD.gn
,
Aug 17 2016
,
Jan 24 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pkotw...@chromium.org
, Aug 4 2016Status: Assigned (was: Untriaged)