New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634389 link

Starred by 3 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Aug 2016
Cc:
█ chrome-system-health-eng@google.com
█ petrcermak@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 589726



Sign in to add a comment

LayoutObject DCHECK failure in browse:news:cnn on Linux

Project Member Reported by petrcermak@chromium.org, Aug 4 2016 
Version: ToT
OS: Linux

Stack trace:

[1:1:0804/101611:FATAL:LayoutObject.cpp(1199)] Check failed: !paintingLayer() || paintingLayer()->needsRepaint(). 
#0 0x7fbe705721de base::debug::StackTrace::StackTrace()
#1 0x7fbe705899fb logging::LogMessage::~LogMessage()
#2 0x7fbe7306718a blink::LayoutObject::invalidateDisplayItemClient()
#3 0x7fbe72fe3792 blink::LayoutBlockFlow::invalidateDisplayItemClients()
#4 0x7fbe730705be blink::(anonymous namespace)::traverseNonCompositingDescendants<>()
#5 0x7fbe730707fe blink::(anonymous namespace)::traverseNonCompositingDescendants<>()
#6 0x7fbe73070529 blink::LayoutObject::invalidateDisplayItemClientsIncludingNonCompositingDescendants()
#7 0x7fbe7301178f blink::LayoutBoxModelObject::styleDidChange()
#8 0x7fbe72ff721d blink::LayoutBox::styleDidChange()
#9 0x7fbe72fcb83d blink::LayoutBlock::styleDidChange()
#10 0x7fbe72fe17ad blink::LayoutBlockFlow::styleDidChange()
#11 0x7fbe73069afd blink::LayoutObject::setStyle()
#12 0x7fbe729701fb blink::Element::recalcOwnStyle()
#13 0x7fbe7296f9d7 blink::Element::recalcStyle()
#14 0x7fbe7291b7e7 blink::ContainerNode::recalcDescendantStyles()
#15 0x7fbe7296fb32 blink::Element::recalcStyle()
#16 0x7fbe7291b7e7 blink::ContainerNode::recalcDescendantStyles()
#17 0x7fbe7296fb32 blink::Element::recalcStyle()
#18 0x7fbe7291b7e7 blink::ContainerNode::recalcDescendantStyles()
#19 0x7fbe7296fb32 blink::Element::recalcStyle()
#20 0x7fbe7291b7e7 blink::ContainerNode::recalcDescendantStyles()
#21 0x7fbe7296fb32 blink::Element::recalcStyle()
#22 0x7fbe7291b7e7 blink::ContainerNode::recalcDescendantStyles()
#23 0x7fbe7296fb32 blink::Element::recalcStyle()
#24 0x7fbe7291b7e7 blink::ContainerNode::recalcDescendantStyles()
#25 0x7fbe7296fb32 blink::Element::recalcStyle()
#26 0x7fbe7291b7e7 blink::ContainerNode::recalcDescendantStyles()
#27 0x7fbe7296fb32 blink::Element::recalcStyle()
#28 0x7fbe7291b7e7 blink::ContainerNode::recalcDescendantStyles()
#29 0x7fbe7296fb32 blink::Element::recalcStyle()
#30 0x7fbe729383f9 blink::Document::updateStyle()
#31 0x7fbe72934f56 blink::Document::updateStyleAndLayoutTree()
#32 0x7fbe7293985e blink::Document::updateStyleAndLayoutTreeIgnorePendingStylesheets()
#33 0x7fbe729391d8 blink::Document::updateStyleAndLayoutIgnorePendingStylesheetsForNode()
#34 0x7fbe7296b5b5 blink::Element::getBoundingClientRect()
#35 0x7fbe7286c0c4 blink::ElementV8Internal::getBoundingClientRectMethodCallback()
#36 0x7fbe6f3c07fe v8::internal::FunctionCallbackArguments::Call()
#37 0x7fbe6f445c7b v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#38 0x7fbe6f444f0b v8::internal::Builtin_Impl_HandleApiCall()
#39 0x7fbe6f444974 v8::internal::Builtin_HandleApiCall()
#40 0x2624bb6063a7 <unknown>

Full log: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/274392/steps/telemetry_perf_unittests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/stdio

What steps will reproduce the problem?
(1) Build Release chrome with DCHECKs enabled
(2) git cl apply 2210083003
(3) tools/perf/run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:cnn --browser=release --device=desktop --chrome-root=.

wangxianzhu: You were the last person to touch the DCHECK (https://codereview.chromium.org/2086613004). Could you please have a look at this?
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a44d109020cd88b093298afdbceacfe2a5f52502

commit a44d109020cd88b093298afdbceacfe2a5f52502
Author: petrcermak <petrcermak@chromium.org>
Date: Thu Aug 04 19:21:28 2016

[system-health] Update ID of bug blocking browse:news:cnn in desktop smoke tests

The original bug that caused the story to fail is now fixed, but another
one is still causing failures.

BUG= 622409 , 634389 

Review-Url: https://codereview.chromium.org/2210083003
Cr-Commit-Position: refs/heads/master@{#409862}

[modify] https://crrev.com/a44d109020cd88b093298afdbceacfe2a5f52502/tools/perf/benchmarks/system_health_smoke_test.py
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f716f1637685a30fd65cdec3a6b130690d56dbf

commit 6f716f1637685a30fd65cdec3a6b130690d56dbf
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Aug 05 15:59:38 2016

Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants

Non-stacked layers under a composited object belong to the object, so
we should not traverse them in traverseNonCompositingDescendants.

BUG= 634389 
TEST=LayoutObjectTest.TraverseNonCompositingDescendantsInPaintOrder
TBR=nednguyen (for enabling the system health smoke test)

Review-Url: https://codereview.chromium.org/2214253002
Cr-Commit-Position: refs/heads/master@{#410070}

[modify] https://crrev.com/6f716f1637685a30fd65cdec3a6b130690d56dbf/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/6f716f1637685a30fd65cdec3a6b130690d56dbf/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
[modify] https://crrev.com/6f716f1637685a30fd65cdec3a6b130690d56dbf/tools/perf/benchmarks/system_health_smoke_test.py

Comment 3 by petrcermak@chromium.org, Aug 5 2016 

I suppose this can now be closed?

Comment 4 by wangxianzhu@chromium.org, Aug 5 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a98b93fe02a0d09bf32e9ffb96879ba63b08634

commit 2a98b93fe02a0d09bf32e9ffb96879ba63b08634
Author: anthonyvd <anthonyvd@chromium.org>
Date: Fri Aug 05 16:13:18 2016

Revert of Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants (patchset #5 id:80001 of https://codereview.chromium.org/2214253002/ )

Reason for revert:
Reverting this CL because it appears to be breaking the following bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/164802

Original issue's description:
> Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants
>
> Non-stacked layers under a composited object belong to the object, so
> we should not traverse them in traverseNonCompositingDescendants.
>
> BUG= 634389 
> TEST=LayoutObjectTest.TraverseNonCompositingDescendantsInPaintOrder
> TBR=nednguyen (for enabling the system health smoke test)
>
> Committed: https://crrev.com/6f716f1637685a30fd65cdec3a6b130690d56dbf
> Cr-Commit-Position: refs/heads/master@{#410070}

TBR=chrishtr@chromium.org,trchen@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 634389 

Review-Url: https://codereview.chromium.org/2219903002
Cr-Commit-Position: refs/heads/master@{#410073}

[modify] https://crrev.com/2a98b93fe02a0d09bf32e9ffb96879ba63b08634/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/2a98b93fe02a0d09bf32e9ffb96879ba63b08634/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
[modify] https://crrev.com/2a98b93fe02a0d09bf32e9ffb96879ba63b08634/tools/perf/benchmarks/system_health_smoke_test.py

Comment 6 by petrcermak@chromium.org, Aug 5 2016

Status: Assigned (was: Fixed)

Comment 7 by petrcermak@chromium.org, Aug 5 2016 

Issue 624587 has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/014f83a2957cac7f59d6e3652fb07271bb0e0fe5

commit 014f83a2957cac7f59d6e3652fb07271bb0e0fe5
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Aug 05 17:54:16 2016

Reland of Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants (patchset #1 id:1 of https://codereview.chromium.org/2219903002/ )

Reason for revert:
Fix conflict.

Original issue's description:
> Revert of Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants (patchset #5 id:80001 of https://codereview.chromium.org/2214253002/ )
>
> Reason for revert:
> Reverting this CL because it appears to be breaking the following bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/164802
>
> Original issue's description:
> > Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants
> >
> > Non-stacked layers under a composited object belong to the object, so
> > we should not traverse them in traverseNonCompositingDescendants.
> >
> > BUG= 634389 
> > TEST=LayoutObjectTest.TraverseNonCompositingDescendantsInPaintOrder
> > TBR=nednguyen (for enabling the system health smoke test)
> >
> > Committed: https://crrev.com/6f716f1637685a30fd65cdec3a6b130690d56dbf
> > Cr-Commit-Position: refs/heads/master@{#410070}
>
> TBR=chrishtr@chromium.org,trchen@chromium.org,wangxianzhu@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 634389 
>
> Committed: https://crrev.com/2a98b93fe02a0d09bf32e9ffb96879ba63b08634
> Cr-Commit-Position: refs/heads/master@{#410073}

TBR=chrishtr@chromium.org,trchen@chromium.org,anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 634389 

Review-Url: https://codereview.chromium.org/2219913002
Cr-Commit-Position: refs/heads/master@{#410102}

[modify] https://crrev.com/014f83a2957cac7f59d6e3652fb07271bb0e0fe5/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/014f83a2957cac7f59d6e3652fb07271bb0e0fe5/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
[modify] https://crrev.com/014f83a2957cac7f59d6e3652fb07271bb0e0fe5/tools/perf/benchmarks/system_health_smoke_test.py

Comment 9 by wangxianzhu@chromium.org, Aug 5 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment