[USS] Migrating from a Directory signin causes a registrar crash |
|||
Issue description1. Launch Chrome with fully directory based sync 2. Sign in and start synicng 3. Restart chrome with --sync-enable-uss-device-info flag 4. See crash in sync_backend_registrar.cc, device info (24) is already present in routing_info_ as a GROUP_PASSIVE (0)
,
Aug 26 2016
,
Sep 14 2016
Any update here Sky?
,
Sep 14 2016
Not really. We talked about this a few weeks ago, I believe the consensus was that the correct approach is to let the directory model types register, and then when we reach registration for USS types, let it override things and clean up anything the directory may have done while registering that particular type.
,
Sep 16 2016
,
Sep 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49c3f34edcbac33f3ad22dad393a6dfd2123c645 commit 49c3f34edcbac33f3ad22dad393a6dfd2123c645 Author: skym <skym@chromium.org> Date: Tue Sep 20 23:14:43 2016 [Sync] NonBlocking type registration clear instead of crashes when also registered as pssive. BUG= 634388 Review-Url: https://codereview.chromium.org/2342353004 Cr-Commit-Position: refs/heads/master@{#419892} [modify] https://crrev.com/49c3f34edcbac33f3ad22dad393a6dfd2123c645/components/sync/driver/glue/sync_backend_registrar.cc [modify] https://crrev.com/49c3f34edcbac33f3ad22dad393a6dfd2123c645/components/sync/driver/glue/sync_backend_registrar_unittest.cc
,
Sep 20 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pav...@chromium.org
, Aug 5 2016