NonJoinable ThreadTests failing on Linux TSAN |
|
Issue descriptionhttps://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/builds/120 with r409597 : [ RUN ] ThreadTest.StartWithOptions_NonJoinable ================== WARNING: ThreadSanitizer: data race (pid=7559) Read of size 8 at 0x7d300000bef8 by main thread: #0 base::Thread::IsRunning() const base/threading/thread.cc:216:7 (base_unittests+0x000000c878ae) #1 ThreadTest_StartWithOptions_NonJoinable_Test::TestBody() base/threading/thread_unittest.cc:194:3 (base_unittests+0x000000a5d494) Previous write of size 8 at 0x7d300000bef8 by thread T4: #0 memset <null> (base_unittests+0x0000004c022a) #1 base::Thread::ThreadMain() base/threading/thread.cc:325:13 (base_unittests+0x000000c87b85) #2 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:70:13 (base_unittests+0x000000c7f57d) As if synchronized via sleep: #0 nanosleep <null> (base_unittests+0x0000004b5237) #1 base::PlatformThread::Sleep(base::TimeDelta) base/threading/platform_thread_posix.cc:177:10 (base_unittests+0x000000c7eee3) #2 ThreadTest_StartWithOptions_NonJoinable_Test::TestBody() base/threading/thread_unittest.cc:191:3 (base_unittests+0x000000a5d48c) Location is heap block of size 184 at 0x7d300000be80 allocated by main thread: #0 operator new(unsigned long) <null> (base_unittests+0x000000515eb2) #1 ThreadTest_StartWithOptions_NonJoinable_Test::TestBody() base/threading/thread_unittest.cc:158:15 (base_unittests+0x000000a5cd86) ---- Similar problem with StartTwiceNonJoinableNotAllowed.
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ef71eefd26cd7c4f3ee5c7d4fbff9aaed2a5459 commit 4ef71eefd26cd7c4f3ee5c7d4fbff9aaed2a5459 Author: reillyg <reillyg@chromium.org> Date: Fri Aug 05 20:54:50 2016 Fix TSAN suppressions for non-joinable ThreadTest. The compiler does not include the class name in the symbol name for the TestBody method so the suppression added in r409915 doesn't work. This patch disables the test under TSan instead. BUG= 634383 , 629716 TBR=thestig@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2218663003 Cr-Commit-Position: refs/heads/master@{#410159} [modify] https://crrev.com/4ef71eefd26cd7c4f3ee5c7d4fbff9aaed2a5459/base/threading/thread_unittest.cc [modify] https://crrev.com/4ef71eefd26cd7c4f3ee5c7d4fbff9aaed2a5459/build/sanitizers/tsan_suppressions.cc |
|
►
Sign in to add a comment |
|
Comment 1 by gab@chromium.org
, Aug 5 2016