use-of-uninitialized-value in UpdateLayers() in layer_tree.cc |
|||
Issue descriptionStarted here: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/68 - previous run was green. r409348 from the change list looks like the most likely culprit. [ RUN ] LayerTreeHostAnimationTestAddAnimationWithTimingFunction.RunMultiThread_DelegatingRenderer ==11145==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x387d6fb in ?? cc/test/fake_picture_layer.cc:52:7 #1 0x364b85e in UpdateLayers cc/trees/layer_tree.cc:53:44 #2 0x36627bb in DoUpdateLayers cc/trees/layer_tree_host.cc:1050:19 #3 0x366167f in UpdateLayers cc/trees/layer_tree_host.cc:918:17 #4 0x37a1931 in BeginMainFrame cc/trees/proxy_main.cc:208:60 ... Uninitialized value was created by a heap allocation #0 0x66e852 in operator new(unsigned long) ??:0 #1 0x2b0f1a1 in Create cc/test/fake_picture_layer.h:20:31 #2 0x2b0f1a1 in SetupTree cc/trees/layer_tree_host_unittest_animation.cc:269:0 #3 0x38b95e9 in DoBeginTest cc/test/layer_tree_test.cc:688:3 ...
,
Aug 4 2016
yeah i'm working on the fix.
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bace8166b2429044074c568b3f431e8682369a27 commit bace8166b2429044074c568b3f431e8682369a27 Author: mlliu <mlliu@chromium.org> Date: Fri Aug 05 17:38:21 2016 Fix for use-of-uninitialized-value Init force_unsuitable_for_gpu_rasterization_ as false in all FakePictureLayer's constructors BUG= 634382 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2207763006 Cr-Commit-Position: refs/heads/master@{#410097} [modify] https://crrev.com/bace8166b2429044074c568b3f431e8682369a27/cc/test/fake_picture_layer.cc
,
Aug 5 2016
,
Aug 5 2016
Thanks for the quick fix. Confirmed MSAN bots are green: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20ChromeOS%20MSan%20Tests/builds/136 |
|||
►
Sign in to add a comment |
|||
Comment 1 by wkorman@chromium.org
, Aug 4 2016