New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634380 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

[Windows][Host] CRD Host MSI fails to install properly

Project Member Reported by joedow@chromium.org, Aug 4 2016

Issue description

Somewhere between build 2812 and 2813 the CRD MSI stopped working correctly.

This may be related to the GN switchover as the MSI from the 2812 build is ~9MB in size (this MSI works great) and the MSI from the 2813 build is ~15MB in size and fails to install properly.

I noticed with the faulty package that the native messaging hosts do not seem to be registered correctly and the package has no icon in the add/remove programs control panel applet.
 
Owner: joedow@chromium.org
Status: Assigned (was: Untriaged)
I do think the GN switchover exposed this problem, however what is interesting is that local, debug GN MSIs worked fine (until Aug 3rd when is_component_build was flipped to true, but this is unrelated).

It seems like it is only a problem with official, release builds.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/348cecd2dbd8cdcbba968c25e54857d209e756ac

commit 348cecd2dbd8cdcbba968c25e54857d209e756ac
Author: joedow <joedow@chromium.org>
Date: Tue Aug 09 17:16:04 2016

Fixing the broken CRD Windows MSI

Just after the GN switch over I found that our official MSIs no longer
contained working binaries.  The MSI was also larger (by ~9MB) and I did not
see an icon in the add/remove programs applet for the CRD service.

All of these problems were caused by a single line in the host GN build file.
When the Windows installation target is built, there is a set of input files
and a set of destinations (for those files) which are fed into a python script.

The lines for chromoting.ico and icudtl.dat were swapped.  This means the MSI
was using icudtl.dat as the icon and chromoting.ico as the icu data file.

In order to try and prevent this issue from occuring again (which is really
easy miss in CR), I've added some organization and comments to the files list.

One note: this issue seems to only repro on release builds though I see the
incorrect files in the generated folders for my local builds without my change.
My assumption is that since I know the MSI is generated correctly (icon shows
up and package size is right) that the official build will also work.

BUG= 634380 

Review-Url: https://codereview.chromium.org/2229673002
Cr-Commit-Position: refs/heads/master@{#410719}

[modify] https://crrev.com/348cecd2dbd8cdcbba968c25e54857d209e756ac/remoting/host/BUILD.gn

Owner: ajnolley@chromium.org
Status: Fixed (was: Started)
This issue should be fixed and our nightly builds should be functional again.  AJ can you take a look and verify there weren't other problems that I missed from the GN switchover?
CRD MSI now installs correctly. Verified Fixed in 54.0.2825.0
Status: Verified (was: Fixed)
Also, found no additional regressions

Sign in to add a comment