New issue
Advanced search Search tips

Issue 634378 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

tab_switching.top_10.reference flaky on Mac HDD Perf (4)

Project Member Reported by petrcermak@chromium.org, Aug 4 2016

Issue description

Revision range first seen: As far as the bot's available history goes
Link to failing step log: https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%284%29/builds/3102/steps/tab_switching.top_10.reference/logs/stdio

The errors are renderer crashes (on various pages):


(INFO) 2016-08-04 08:22:43,219 browser.DumpStateUponFailure:346  *************** BROWSER STANDARD OUTPUT ***************
(INFO) 2016-08-04 08:22:43,219 browser.DumpStateUponFailure:348  2016-08-04 08:20:40.796 Google Chrome[17874:172851] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7fd47a700840>
2016-08-04 08:20:40.797 Google Chrome[17874:172851] Call stack:
(
    "+callStackSymbols disabled for performance reasons"
)

(INFO) 2016-08-04 08:22:43,219 browser.DumpStateUponFailure:351  *********** END OF BROWSER STANDARD OUTPUT ************
(INFO) 2016-08-04 08:22:43,219 browser.DumpStateUponFailure:353  ********************* BROWSER LOG *********************
(INFO) 2016-08-04 08:22:43,220 browser.DumpStateUponFailure:355  No log file
(INFO) 2016-08-04 08:22:43,220 browser.DumpStateUponFailure:358  ***************** END OF BROWSER LOG ******************

Screenshot: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_0-2016-08-04_08-22-4982955.png

Not sure if relevant: The screenshot contains a dialog saying:
"The last time you opened Chrome, it unexpectedly quit while
reopening windows. Do you want to try to reopen its windows again?".

The benchmark failed 5 times out of the last 20 runs (more than 1/5), so I'm going to disable the test according perf sheriffing instructions: https://chromium.googlesource.com/chromium/src/+/master/tools/perf/docs/perf_bot_sheriffing.md#Handle-Test-Failures

If the test is disabled, please downgrade to Pri-2.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e033ad5b1969df84eed1e703176bb1165c7577e6

commit e033ad5b1969df84eed1e703176bb1165c7577e6
Author: petrcermak <petrcermak@chromium.org>
Date: Fri Aug 05 09:07:29 2016

[perf] Disable tab_switching.top_10 on mac-reference

Rationale: The benchmark is failing flakily on Mac HDD Perf (4).

BUG= 634378 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com

Review-Url: https://codereview.chromium.org/2213043002
Cr-Commit-Position: refs/heads/master@{#410017}

[modify] https://crrev.com/e033ad5b1969df84eed1e703176bb1165c7577e6/tools/perf/benchmarks/tab_switching.py

Cc: petrcermak@chromium.org
Labels: -Pri-1 Pri-2
Owner: dtu@chromium.org
The benchmark is now disabled, so I'm lowering the priority and re-assigning to the author of the benchmark (https://chromiumcodereview.appspot.com/23618042).

Comment 3 by dtu@chromium.org, Aug 5 2016

Isn't everything flaky on Mac HDD Perf? Is this test more flaky than others?
Yes, but this benchmark was more flaky than others (see the sentence regarding failure frequency in the initial post).
Status: Assigned (was: Untriaged)
Cc: -petrcermak@chromium.org
Cc: -petrcermak@chromium.org

Comment 8 by dtu@chromium.org, Feb 8 2017

Status: Archived (was: Assigned)

Sign in to add a comment