Some client-lib code lives in //services/ui/common. These should move into //services/ui/public instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62c311322b6343e6fd148f9b81d500e795242228 commit 62c311322b6343e6fd148f9b81d500e795242228 Author: sadrul <sadrul@chromium.org> Date: Thu Aug 11 04:13:17 2016 services/ui: Inject GpuService instance where needed, instead of singleton. ui::GLES2Context uses the GpuService instance to establish a channel to the GPU process. Instead of using the global singleton, pass through the GpuService instance to ui::GLES2Context through the ui::OutputSurface. This removes the last usage of the GpuService singleton, which means this code can be moved into the client-lib, where it belongs. BUG= 634377 TBR=ben@ for change related to new API in content/renderer Review-Url: https://codereview.chromium.org/2233003003 Cr-Commit-Position: refs/heads/master@{#411262} [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/ash/mus/window_manager_application.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/content/renderer/mus/render_widget_mus_connection.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/content/renderer/mus/render_widget_mus_connection.h [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/content/renderer/render_thread_impl.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/common/gpu_service.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/common/gpu_service.h [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/demo/mus_demo.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/public/cpp/bitmap_uploader.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/public/cpp/bitmap_uploader.h [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/public/cpp/context_provider.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/public/cpp/context_provider.h [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/public/cpp/gles2_context.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/public/cpp/gles2_context.h [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/public/cpp/output_surface.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/services/ui/public/cpp/output_surface.h [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/ui/views/mus/surface_context_factory.cc [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/ui/views/mus/surface_context_factory.h [modify] https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228/ui/views/mus/window_manager_connection.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9909744795ee6b8039df2d9301825fd4c155ec0c commit 9909744795ee6b8039df2d9301825fd4c155ec0c Author: sadrul <sadrul@chromium.org> Date: Thu Aug 11 16:10:12 2016 services/ui: Move some files into the client lib. Move the following out of ui/common into the public client-lib: . GpuService . GpuMemoryBufferImpl . MojoGpuMemoryBuffer . MojoGpuMemoryBufferManager . MojoBufferBacking These are only used by the clients, so there's no reason to build these into the server as well. BUG= 634377 TBR=ben@ for trivial content/ changes. Review-Url: https://codereview.chromium.org/2184943002 Cr-Commit-Position: refs/heads/master@{#411345} [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/ash/mus/window_manager_application.cc [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/chrome/browser/DEPS [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/content/browser/BUILD.gn [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/content/browser/compositor/DEPS [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/content/browser/renderer_host/DEPS [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/content/renderer/BUILD.gn [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/content/renderer/render_thread_impl.cc [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/mash/login/BUILD.gn [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/common/BUILD.gn [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/demo/mus_demo.cc [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/BUILD.gn [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/command_buffer_client_impl.cc [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/gles2_context.cc [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/gpu_memory_buffer_impl.cc [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/gpu_memory_buffer_impl.h [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/gpu_service.cc [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/gpu_service.h [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/mojo_buffer_backing.cc [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/mojo_buffer_backing.h [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/mojo_gpu_memory_buffer.cc [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/mojo_gpu_memory_buffer.h [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc [rename] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/mojo_gpu_memory_buffer_manager.h [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/public/cpp/tests/BUILD.gn [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/services/ui/surfaces/direct_output_surface_ozone.cc [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/ui/views/mus/BUILD.gn [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/ui/views/mus/surface_context_factory.cc [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/ui/views/mus/surface_context_factory.h [modify] https://crrev.com/9909744795ee6b8039df2d9301825fd4c155ec0c/ui/views/mus/window_manager_connection.cc
bulk verified
Comment 1 by bugdroid1@chromium.org
, Aug 11 2016