New issue
Advanced search Search tips

Issue 634375 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Support Debug Component builds of Chromoting

Project Member Reported by lambroslambrou@chromium.org, Aug 4 2016

Issue description

Debug builds of Chromium now default to Component build:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/kk47YfzT0vQ

If it's simple to do, we should consider fixing Chromoting to work with is_component_build=true.

Alternatively, we should update the docs to require
is_component_build=false
when doing Debug builds.

For example, remoting_apk builds fine, but fails at runtime with:
E AndroidRuntime: java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/org.chromium.chromoting-1/base.apk"],nativeLibraryDirectories=[/data/app/org.chromium.chromoting-1/lib/arm, /data/app/org.chromium.chromoting-1/base.apk!/lib/armeabi-v7a, /vendor/lib, /system/lib]]] couldn't find "libremoting_client_jni.so"

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa2204311b7b12bf707b1f670ca6ebe3b1e26250

commit fa2204311b7b12bf707b1f670ca6ebe3b1e26250
Author: yuweih <yuweih@chromium.org>
Date: Tue Aug 09 02:44:08 2016

[Remoting Android] Fix component build runtime error

Component build has been turned on by default but the generated Android client
doesn't work since the JNI shared library cannot be located. The issue is that
turning on the component build flag will add a ".cr" suffix to the name of the
library while we always load `remoting_client_jni` unconditionally.

This CL adds fallback for loading `remoting_client_jni.cr` if
`remoting_client_jni` can't be loaded.

BUG= 634375 

Review-Url: https://codereview.chromium.org/2228783002
Cr-Commit-Position: refs/heads/master@{#410550}

[modify] https://crrev.com/fa2204311b7b12bf707b1f670ca6ebe3b1e26250/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java

Owner: yuweih@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment