Issue metadata
Sign in to add a comment
|
Undisabled Dialog makes media.tough_video_cases flaky on Mac HDD Perf (5) |
||||||||||||||||||||||
Issue descriptionRevision range first seen: As far as the bot's available history goes Link to failing step log: https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%285%29/builds/2337/steps/media.tough_video_cases/logs/stdio Error (different story in different failing build, but always seems to contain "no video encoder found for 'avc1'"): (INFO) 2016-08-04 06:32:48,310 browser.DumpStateUponFailure:346 *************** BROWSER STANDARD OUTPUT *************** (INFO) 2016-08-04 06:32:48,311 browser.DumpStateUponFailure:348 2016-08-04 06:30:31.501 Google Chrome[7359:57163] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7f8cf1775180> 2016-08-04 06:30:31.502 Google Chrome[7359:57163] Call stack: ( "+callStackSymbols disabled for performance reasons" ) <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1' [13:30:31.899] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.238/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245 [13:30:31.899] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.238/Sources/VideoToolbox/VTCompressionSession.c line 946 [7365:29731:0804/063045:ERROR:ffmpeg_demuxer.cc(1594)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0 [7365:29731:0804/063057:ERROR:ffmpeg_demuxer.cc(1594)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0 [7365:29731:0804/063110:ERROR:ffmpeg_demuxer.cc(1594)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0 [7365:29731:0804/063124:ERROR:ffmpeg_demuxer.cc(1594)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0 [7365:29731:0804/063139:ERROR:ffmpeg_demuxer.cc(1594)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0 [7365:29731:0804/063205:ERROR:ffmpeg_demuxer.cc(1594)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0 (INFO) 2016-08-04 06:32:48,311 browser.DumpStateUponFailure:351 *********** END OF BROWSER STANDARD OUTPUT ************ Screenshot: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_0-2016-08-04_06-39-3153138.png Not sure if relevant: the screenshot contains a dialog saying: "The last time you opened Chrome, it unexpectedly quit while reopening windows. Do you want to try to reopen its windows again?". The benchmark failed "only" 3 times in the past 20 builds, so I'm *not* going to disable it now (less than 1/5, see https://chromium.googlesource.com/chromium/src/+/master/tools/perf/docs/perf_bot_sheriffing.md#Handle-Test-Failures). sandersd,crouleau,videostack-eng: Could someone please look into this? If the test is disabled, please downgrade to Pri-2.
,
Aug 8 2016
I think that we should investigate this: messages like this one are generally prevented in Telemetry by passing a flag to Chrome. sullivan@, do you know who would be a good person to get in touch with re: whether such a flag exists? A code search for the UI string didn't turn anything up, possibly because it's hidden in some i18n database.
,
Aug 8 2016
+rschoen: Do you have any idea who we could ping about this message and whether there is a flag to disable? "The last time you opened Chrome, it unexpectedly quit while reopening windows. Do you want to try to reopen its windows again?"
,
Aug 9 2016
/bump rschoen@
,
Aug 9 2016
+ivanpe are you familiar with this dialog or know who would be?
,
Aug 11 2016
,
Aug 11 2016
I'm not familiar with that dialog. I don't usually work on Chrome codebase so I'm not sure who would be a better person to talk to.
,
Aug 15 2016
,
Aug 15 2016
this is P1 bug. Dale, can you take a look or assign appropriately? I am not sure it does belong to videostack team though.
,
Aug 15 2016
We really just need to find someone who knows how to disable the dialog. I'm looking into the code now to find someone who might know.
,
Aug 15 2016
https://bugs.chromium.org/p/chromium/issues/detail?id=164213 (specifically comment 5 and comment 6) tells me that the dialog is an OSX dialog, so we actually need to find a configuration option to change on OSX on the bots, not a flag in Chrome (I think).
,
Aug 15 2016
Charlie, is there a component for telemetry bug that we can put this under? This is completely unrelated to Internals>Media>Video AFAICT.
,
Aug 15 2016
,
Aug 29 2016
Moving this to Tests > Telemetry.
,
Oct 3 2016
Ping. Still flaky. I think this should be pri-2.
,
Oct 3 2016
Since this is media benchmark's failure, assign to crouleau@ for triaging
,
Oct 5 2016
,
Oct 5 2016
,
Oct 10 2016
This isn't a media problem. This is a telemetry problem. See #11.
,
Oct 11 2016
Erik: do you know if we have chrome flag to disable the pop up in https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_0-2016-08-04_06-39-3153138.png? If it doesn't exist, you know who should we ask for help in adding such flag?
,
Oct 11 2016
Ah nvm, looks like this is a Mac OS feature & can be disabled by running "defaults write com.apple.CrashReporter DialogType none" (http://www.defaults-write.com/disable-os-x-crash-report-dialog-window/)
,
Oct 25 2016
Ethan: can you take this bug?
,
Oct 26 2016
Is this something we'd want in telemetry, or something labs should do when configuring the machine?
,
Oct 26 2016
It's not a too intrusive change for the platform, so I think putting it in telemetry is the easiest option.
,
Oct 26 2016
Do we have a timeline for when this will be fixed?
,
Oct 31 2016
+ yihongg@ FYI eakuefner@, are you working on this?
,
Nov 11 2016
Sorry, missed this originally; I'll pick this up tomorrow and it seems like it should be a straightforward fix.
,
Nov 11 2016
Ned, it doesn't seem like the solution you linked to is for this problem, but I did a little research and it seems like the correct fix is along similar lines; see http://stackoverflow.com/questions/20226802/disable-the-last-time-you-opened-it-unexpectedly-quit-while-reopening-window
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/337c9a5cc3cd86352eac5b05f8ce48e3eb3b2153 commit 337c9a5cc3cd86352eac5b05f8ce48e3eb3b2153 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Tue Nov 15 03:29:33 2016 Roll src/third_party/catapult/ 739385f90..4bdc7a6f9 (4 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/739385f90b40..4bdc7a6f976f $ git log 739385f90..4bdc7a6f9 --date=short --no-merges --format='%ad %ae %s' 2016-11-14 benjhayden Truncate tall histogram bins. 2016-11-14 robertocn [Dashboard] Let admins trigger staging bisects. 2016-11-14 eakuefner [Telemetry] Prevent Resume dialog from being shown on Mac 2016-11-14 benjhayden Rename ValueRef to HistogramRef. BUG= 663599 , 634367 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2498873005 Cr-Commit-Position: refs/heads/master@{#432068} [modify] https://crrev.com/337c9a5cc3cd86352eac5b05f8ce48e3eb3b2153/DEPS
,
Nov 15 2016
This should be fixed; please verify or re-open. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by crouleau@chromium.org
, Aug 5 2016