New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634366 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 536818
issue 599056
issue 626500



Sign in to add a comment

bluetooth: Update name in chooser when device changes name

Project Member Reported by ortuno@chromium.org, Aug 4 2016

Issue description

We should update the device's name in the chooser if the platform finds a new name.

 
Blocking: 536818
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb5ba23019e1c6cd772c51c34a35104a3e39dd99

commit bb5ba23019e1c6cd772c51c34a35104a3e39dd99
Author: juncai <juncai@chromium.org>
Date: Tue Aug 16 18:01:13 2016

Update device name in chooser when device changes name (desktops)

This CL modified code to update device name in chooser when device
changes its name. Also added test code to cover the changed code.

BUG= 634366 

Review-Url: https://codereview.chromium.org/2242943002
Cr-Commit-Position: refs/heads/master@{#412290}

[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/chooser_controller/chooser_controller.h
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/chooser_controller/mock_chooser_controller.cc
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/chooser_controller/mock_chooser_controller.h
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.h
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/ui/views/chooser_content_view.cc
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/ui/views/chooser_content_view.h
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/ui/views/chooser_content_view_unittest.cc
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/bb5ba23019e1c6cd772c51c34a35104a3e39dd99/content/public/browser/bluetooth_chooser.h

Comment 3 by ortuno@chromium.org, Aug 17 2016

Status: Started (was: Assigned)
Android WIP: http://crrev.com/2256893003
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54227ff72da835d9c6f6d9a46d299fb3cdb79d7f

commit 54227ff72da835d9c6f6d9a46d299fb3cdb79d7f
Author: ortuno <ortuno@chromium.org>
Date: Tue Aug 23 01:47:53 2016

bluetooth: Update the item's description on android.

For example when a device changes names we want to show the new name.

BUG= 634366 

Review-Url: https://codereview.chromium.org/2256893003
Cr-Commit-Position: refs/heads/master@{#413622}

[modify] https://crrev.com/54227ff72da835d9c6f6d9a46d299fb3cdb79d7f/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
[modify] https://crrev.com/54227ff72da835d9c6f6d9a46d299fb3cdb79d7f/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

Comment 5 by ortuno@chromium.org, Aug 23 2016

Status: Fixed (was: Started)

Sign in to add a comment