[Media Router WebUI] Append new sinks at the end of the list. |
||||||
Issue descriptionCurrently, when the sink list is updated in the WebUI, we just replace |sinksToShow_| in the container. This sometimes causes re-sorting and sinks suddenly appear in a different place. This isn't a great experience for users if they were about to click on a sink target, then the list updates. This can result in users casting to the wrong sink. Current proposal is to append all new sinks that are updated in the WebUI to the end of the shown sink list menu.
,
Aug 4 2016
Any chance we can get this into M54 (and then merged back to M53)?
,
Aug 4 2016
M54 + M53 merge SGTM.
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e23faebb13dc082e283a8e53d460a7cb8625aabd commit e23faebb13dc082e283a8e53d460a7cb8625aabd Author: apacible <apacible@chromium.org> Date: Tue Aug 09 05:33:16 2016 [Media Router WebUI] Append new sinks to the end of the list. Currently, when the sink list is updated in the WebUI, we just replace |sinksToShow_| in the container. This sometimes causes re-sorting and sinks suddenly appear in a different place. This can result in accidental casting to the wrong sink. This change appends new sinks to the end of the sink list. A user who has incrementally discovered sinks will see the dialog grow vertically as new sinks are appended at the bottom of the list. Also updated variable naming to make it more easily readable. BUG= 634365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2221933003 Cr-Commit-Position: refs/heads/master@{#410585} [modify] https://crrev.com/e23faebb13dc082e283a8e53d460a7cb8625aabd/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/e23faebb13dc082e283a8e53d460a7cb8625aabd/chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js
,
Aug 9 2016
,
Aug 10 2016
,
Aug 10 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e27d22a53409415b174df1b775ae5de195b67b9f commit e27d22a53409415b174df1b775ae5de195b67b9f Author: Jennifer Apacible <apacible@chromium.org> Date: Wed Aug 10 16:47:13 2016 [Media Router WebUI] Append new sinks to the end of the list. Currently, when the sink list is updated in the WebUI, we just replace |sinksToShow_| in the container. This sometimes causes re-sorting and sinks suddenly appear in a different place. This can result in accidental casting to the wrong sink. This change appends new sinks to the end of the sink list. A user who has incrementally discovered sinks will see the dialog grow vertically as new sinks are appended at the bottom of the list. Also updated variable naming to make it more easily readable. BUG= 634365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2221933003 Cr-Commit-Position: refs/heads/master@{#410585} (cherry picked from commit e23faebb13dc082e283a8e53d460a7cb8625aabd) Review URL: https://codereview.chromium.org/2231893002 . Cr-Commit-Position: refs/branch-heads/2785@{#548} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/e27d22a53409415b174df1b775ae5de195b67b9f/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/e27d22a53409415b174df1b775ae5de195b67b9f/chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by apaci...@chromium.org
, Aug 4 2016