Build cronet targets on the CQ |
|||||||||
Issue descriptionAll of the cronet bots are currently red due to a compile failure. This failure was not caught by the CQ because it appears no cronet code is built by CQ bots. We should add a cronet CQ bot so the cronet bots (There are 10 bots here https://build.chromium.org/p/chromium.android) don't keep getting broken.
,
Aug 4 2016
Note that, because cronet uses a different set of gn arguments, this would require a separate cq bot.
,
Aug 4 2016
,
Aug 4 2016
It would, but just a compile-only bot would be a start, and cronet is relatively small so it hopefully shouldn't require a lot of bots to keep up if it's not running tests.
,
Aug 4 2016
,
Aug 4 2016
,
Aug 9 2016
This is certainly possible, especially since they would be compile-only and can run on cheap VMs. But how often do the cronet bots break due to bad CLs making it through the CQ? Can someone confirm that it happens frequently enough to warrant its own CQ bot? If not, I'd say the current setup is WAI Re #2: What are these args that couldn't just be added to one of the CQ bots we already have? (I'm guess things like 'disable_file_support' wouldn't jive well with other builds...)
,
Aug 9 2016
#7: I haven't tried to do a cronet build & run the chromium tests, if that's what you're asking, but the gn flags that cronet uses (https://codesearch.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=0&l=2093) are all deviations from how we build chromium (and chrome). We'd either need to run a separate compile/test cycle on the same bot (either in the same build or in a different build) or change how we build chromium to suit cronet. I think the cheap VMs + an additional CQ bot are vastly preferable to either.
,
Aug 18 2016
,
Sep 2 2016
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64e96a0f101d325646f3759b676dc422612c7fd8 commit 64e96a0f101d325646f3759b676dc422612c7fd8 Author: jbudorick <jbudorick@chromium.org> Date: Wed Sep 07 17:49:37 2016 [Android] Add configurations for cronet continuous builder + trybot. BUG= 634350 Review-Url: https://codereview.chromium.org/2302353003 Cr-Commit-Position: refs/heads/master@{#416989} [modify] https://crrev.com/64e96a0f101d325646f3759b676dc422612c7fd8/testing/buildbot/chromium.android.json [modify] https://crrev.com/64e96a0f101d325646f3759b676dc422612c7fd8/tools/mb/mb_config.pyl
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/239067c0b2b9d9f905d8a0925cd13439edead8ae commit 239067c0b2b9d9f905d8a0925cd13439edead8ae Author: jbudorick <jbudorick@chromium.org> Date: Wed Sep 07 20:48:42 2016 [Android] Set up continuous builder + trybot for cronet. Uses the chromium recipe, unlike the other cronet bots. BUG= 634350 Review-Url: https://codereview.chromium.org/2308683002 [modify] https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae/masters/master.chromium.android/builders.pyl [modify] https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae/masters/master.tryserver.chromium.android/builders.pyl [modify] https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae/scripts/slave/recipe_modules/chromium_tests/chromium_android.py [modify] https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae/scripts/slave/recipe_modules/chromium_tests/trybots.py [add] https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Cronet_Builder.json [add] https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_cronet.json
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ae131437f5c3c5ea9e4446bc11416cca8290cb2 commit 3ae131437f5c3c5ea9e4446bc11416cca8290cb2 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Sep 07 22:11:04 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae [Android] Set up continuous builder + trybot for cronet. (jbudorick@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 634350 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2318123003 Cr-Commit-Position: refs/heads/master@{#417080} [modify] https://crrev.com/3ae131437f5c3c5ea9e4446bc11416cca8290cb2/infra/config/recipes.cfg
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ae131437f5c3c5ea9e4446bc11416cca8290cb2 commit 3ae131437f5c3c5ea9e4446bc11416cca8290cb2 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Sep 07 22:11:04 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae [Android] Set up continuous builder + trybot for cronet. (jbudorick@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 634350 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2318123003 Cr-Commit-Position: refs/heads/master@{#417080} [modify] https://crrev.com/3ae131437f5c3c5ea9e4446bc11416cca8290cb2/infra/config/recipes.cfg
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/7761fc03d8cb1d604f9a58af630194e7633228c4 commit 7761fc03d8cb1d604f9a58af630194e7633228c4 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Sep 07 22:34:24 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/8373aa1227eccc13db3b1c14e3699d4282b9ff1f Convert commandline to str in recipe_modules/goma (tikuta@chromium.org) https://crrev.com/191bb2bd43d119b86f82d72a34dd65c86f0caa55 Fix GYP-based closure try bots while they continue getting ported to GN (dbeam@chromium.org) https://crrev.com/11785fb7f116f51bb6442bbbe5b4096055448e57 Add counting the number of CPU's in goma module (tikuta@chromium.org) https://crrev.com/a29ebd495ab583c49bc8b0d1954c536e9eb48b10 goma canary; should fail when goma start failed. (yyanagisawa@chromium.org) https://crrev.com/383c08f181a0bd59c5c34628be1042c05a88727a WebRTC: Change Google Storage bucket for logcat dumps (kjellander@chromium.org) https://crrev.com/13856309f4dff0281657c5f282c5c99e55096947 chromium_android: fix dangerous default value (phajdan.jr@chromium.org) https://crrev.com/b9d0b44a84c7dc24fe9f69367fe8a05cfbb70d01 Delete android/perf recipe (phajdan.jr@chromium.org) https://crrev.com/cf533954eb5866ebdd425f81806d30264e79021c V8: Switch on MB on older branches (machenbach@chromium.org) https://crrev.com/1b0324b4e3dfad7455edaf416134848245331167 Convert Site Isolation Win layout tests to run with --site-per-process. (alexmos@chromium.org) https://crrev.com/378036a294f1ead296e09284dc83387dcacedd1f Revert of Fix GYP-based closure try bots while they continue getting ported to GN (patchset #6 id:100001 of https://codereview.chromium.org/2315123002/ ) (dbeam@chromium.org) https://crrev.com/f9c6f0966908f1d125ea8f519cf31b8a84aff886 DevTools: Update devtools recipe with tryserver logic (chenwilliam@chromium.org) https://crrev.com/ece649094b8b366432846b994819eca89d790cf9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/b6837ba5832ef4b25103a9e9680e7cd0c275ef41 [Android] Enable USB reset on perf bots. (jbudorick@chromium.org) https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae [Android] Set up continuous builder + trybot for cronet. (jbudorick@chromium.org) https://crrev.com/8e6fcd316b9f3551ec6618e39adb516accd0b0f9 Re-add perf-id and results-url. (dtu@chromium.org) depot_tools: https://crrev.com/f0b0378318a0bca451dc05303ba3c0971b249103 Remove gerrit_rebase_patch_ref flag from bot_update API (andybons@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=none,634350,chromium:616035,642046,644563,644721,477150,544330,637806,584079,417518,644370,612417,642194 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2319333002 [modify] https://crrev.com/7761fc03d8cb1d604f9a58af630194e7633228c4/infra/config/recipes.cfg
,
Sep 8 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/d7cfc709a57d0b9a63d17ac8cc1dc3b580f3444a commit d7cfc709a57d0b9a63d17ac8cc1dc3b580f3444a Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 08 03:24:31 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/964415b76b6eee637cce948faa94f5f99dd4d20c commit 964415b76b6eee637cce948faa94f5f99dd4d20c Author: jbudorick <jbudorick@chromium.org> Date: Thu Sep 08 14:55:19 2016 [Android] Turn on android_cronet CQ builder at 10%. BUG= 634350 Review-Url: https://codereview.chromium.org/2313373003 Cr-Commit-Position: refs/heads/master@{#417294} [modify] https://crrev.com/964415b76b6eee637cce948faa94f5f99dd4d20c/infra/config/cq.cfg
,
Sep 8 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/123ab8e8c28aa8123164ea71bed02451152326ef commit 123ab8e8c28aa8123164ea71bed02451152326ef Author: jbudorick <jbudorick@chromium.org> Date: Fri Sep 09 20:12:06 2016 [Android] Fix cronet trybot name. BUG= 634350 Review-Url: https://codereview.chromium.org/2325003003 Cr-Commit-Position: refs/heads/master@{#417683} [modify] https://crrev.com/123ab8e8c28aa8123164ea71bed02451152326ef/tools/mb/mb_config.pyl
,
Sep 12 2016
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/9bf6c2595e8e512c721098d707d20fbfc50858f9 commit 9bf6c2595e8e512c721098d707d20fbfc50858f9 Author: jbudorick <jbudorick@chromium.org> Date: Mon Sep 12 22:09:00 2016 Add 6 GCE instances to ccompute_bots_cq on tryserver.chromium.android. Allocated in crbug.com/645969 BUG= 634350 Review-Url: https://codereview.chromium.org/2336783002 [modify] https://crrev.com/9bf6c2595e8e512c721098d707d20fbfc50858f9/masters/master.tryserver.chromium.android/builders.pyl
,
Sep 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager.git/+/5a98a86037075e0fe95be9c217b6af6310072952 commit 5a98a86037075e0fe95be9c217b6af6310072952 Author: jbudorick <jbudorick@google.com> Date: Mon Sep 12 22:15:14 2016
,
Sep 12 2016
android_cronet seems fine & the capacity added in #21/#22 should cover its needs, so I'm planning to bump it to 100% tomorrow.
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fdb9864233e45dcef2c48600c1ec90900142cc5 commit 5fdb9864233e45dcef2c48600c1ec90900142cc5 Author: jbudorick <jbudorick@chromium.org> Date: Tue Sep 13 18:40:18 2016 Bump tryserver.chromium.android:android_cronet to 100% cq experiment. BUG= 634350 Review-Url: https://codereview.chromium.org/2338533002 Cr-Commit-Position: refs/heads/master@{#418313} [modify] https://crrev.com/5fdb9864233e45dcef2c48600c1ec90900142cc5/infra/config/cq.cfg
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a2a7f24a87ff5423bcf815173b2f3bcc4821107 commit 8a2a7f24a87ff5423bcf815173b2f3bcc4821107 Author: jbudorick <jbudorick@chromium.org> Date: Thu Oct 20 14:29:24 2016 Promote tryserver.chromium.android:android_cronet to cq. BUG= 634350 Review-Url: https://chromiumcodereview.appspot.com/2440623002 Cr-Commit-Position: refs/heads/master@{#426473} [modify] https://crrev.com/8a2a7f24a87ff5423bcf815173b2f3bcc4821107/infra/config/cq.cfg
,
Oct 20 2016
,
Oct 20 2016
Yay! Thanks a lot for making Cronet a first class project. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jbudorick@chromium.org
, Aug 4 2016Components: -Infra>CQ Infra>Client>Android
Labels: OS-Android