New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634340 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

new Proxy(new Error, ...) never contains stacktrace

Reported by michalwa...@gmail.com, Aug 4 2016

Issue description

Chrome Version       :	aa7c8d23c098e96a388ffedf6698230bda650bb3-refs/branch-heads/2704@{#723}
Other browsers tested:
    Firefox: FAIL (empty string)

What steps will reproduce the problem?
(1) Write into JS console:
try { throw new Proxy(new Error, {}); } catch(e) {console.log(e.stack)}


What is the expected result?
"Error\n    at <anonymous>:1:13"

What happens instead?
undefined



 
Components: Internals>Network>Proxy
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Tested this issue on Mac OS 10.11.6 using chrome latest canary M54-54.0.2820.0. By writing the code "try { throw new Proxy(new Error, {}); } catch(e) {console.log(e.stack)}" observed error saying "Error at <anonymous>:1:23".

michalwadas@ - Could you please let us know on which platform you are facing this issue including your chrome version details.

Thanks!

Screen Shot 2016-08-05 at 3.19.00 PM.png
31.1 KB View Download
My user agent is:
Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

My Chrome is built from commit aa7c8d23c098e96a388ffedf6698230bda650bb3, it's Windows 10, 64bit OS and 64bit Chrome.
no_stack_trace.png
41.7 KB View Download
Components: -Internals>Network>Proxy Blink>JavaScript
Components: -Blink>JavaScript Blink>JavaScript>Language
Labels: -Pri-3 -Needs-Feedback Needs-Bisect Pri-2
Status: Available (was: Unconfirmed)
Cc: adamk@chromium.org
On Chrome 52 undefined is returned too.

Comment 8 by adamk@chromium.org, Aug 8 2016

Cc: jgruber@chromium.org
Components: -Blink>JavaScript>Language Blink>JavaScript>Runtime
Owner: yangguo@chromium.org
Status: Assigned (was: Available)
No throwing is necessary to compare the results, just look at:

console.log(new Error().stack)

vs

console.log(new Proxy(new Error(), {}).stack)
As brajkumar said, this works on the current tip of three. I suspect it was fixed by the recent move of Error code to C++.
Labels: -Type-Bug -Needs-Bisect hasbisect OS-Linux OS-Mac OS-Windows Type-Bug-Regression
Able to reproduce this issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.6 using chrome Stable M52-52.0.2743.116.

Bisect Information:
=====================
Good build: 49.0.2618.0 
Bad Build : 49.0.2620.0 

Change Log URL: https://chromium.googlesource.com/chromium/src/+log/11c12b4e3aff8cf2d191ce60c298bd528cce3a07..c85ed637028905bab1ed91b6a748515b4438c31d

V8 Change Log: https://chromium.googlesource.com/v8/v8/+log/6d5737e4..65f09d9b

From the above log suspecting below change

Review URL: https://codereview.chromium.org/1580783002

Could anyone please check whether the above suspect is the root cause for this issue? If yes, please feel free to assign to him.

Thanks!
Confirmed the fix is https://codereview.chromium.org/2142933003.

Adam, is it ok to close this?
Labels: -Type-Bug-Regression Type-Bug
Status: Fixed (was: Assigned)
Given the bisect, yeah, this was broken from the minute we shipped proxies until Jakob fixed it (so it's actually not a regression). Marking as fixed!

Sign in to add a comment