New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634338 link

Starred by 2 users
Status: Fixed
Owner:
dmazz...@chromium.org
Closed: Aug 2016
Cc:
█ nek...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 633598



Sign in to add a comment

Build warning: “Error : Unexpected comment after symbol after” since 958086533d06

Project Member Reported by mark@chromium.org, Aug 4 2016 
In https://crrev.com/958086533d06dfbd0f172405036e78be79ba283f (https://codereview.chromium.org/2207573002,  bug 633598 ), ax_enums.idl looks like

https://chromium.googlesource.com/chromium/src/+/958086533d06dfbd0f172405036e78be79ba283f/ui/accessibility/ax_enums.idl#522

517    // Compares two nodes in an accessibility tree in pre-order traversal.
518    enum AXTreeOrder {
519      undefined,  // Not in the same tree, or other error.
520      before,     // First node is before the second one.
521      equal,      // Nodes are the same.
522      after       // First node is after the second one.
523    };

This triggers warnings in my builds:

[278/18576] ACTION //ui/accessibility:...rator(//build/toolchain/mac:clang_x64)
../../ui/accessibility/ax_enums.idl(522) : Error : Unexpected comment after symbol after.

Comment 1 by dmazz...@chromium.org, Aug 4 2016

Status: Started (was: Assigned)
That's odd, I didn't see that warning.

Let me try adding a comma after that last enum value and see if that fixes it.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42ace53134381b6d6bc067ad1e96bb34daaed760

commit 42ace53134381b6d6bc067ad1e96bb34daaed760
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Aug 04 17:01:35 2016

Workaround for warning parsing comment in idl

A comment is not expected after the last enum value,
apparently...

BUG= 634338 
TBR=nektar@chromium.org

Review-Url: https://codereview.chromium.org/2207643005
Cr-Commit-Position: refs/heads/master@{#409813}

[modify] https://crrev.com/42ace53134381b6d6bc067ad1e96bb34daaed760/ui/accessibility/ax_enums.idl

Comment 3 by dmazz...@chromium.org, Aug 4 2016

Status: Fixed (was: Started)

Comment 4 by thakis@chromium.org, Aug 4 2016 

Thanks for the fix.

Can we make ax_gen_schema_generator actually fail on errors instead of just printing as well? Then the CQ would've caught this. (Or is there a separate bug for that already?)

Comment 5 by dmazz...@chromium.org, Aug 15 2016 

We're considering switching to a .mojom file instead, which seems to be much better maintained than the schema generator script.
►

Sign in to add a comment