New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634330 link

Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Enable custom enter key on virtual keyboards

Project Member Reported by tdres...@chromium.org, Aug 4 2016

Issue description

Mozilla's solution to this is "mozactionhint"

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-mozactionhint

We should look into standardizing this.
 
Cc: aelias@chromium.org changwan@chromium.org
Components: -IO>Keyboard UI>Input>Text>IME
Summary: Enable custom enter key on virtual keyboards (was: Enable custom enter key on virtual keyboards.)

Comment 2 by owe...@chromium.org, Sep 26 2016

Any chance this could fit into Q4 planning?

Comment 3 by aelias@chromium.org, Sep 26 2016

Related: in  http://crbug.com/648986  we're discussing improving the heuristic for autoselecting the action.
I wrote a brief spec before tpac. And I just need to modify it a bit more. I presume it would fit into q4. 
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f4ddc2a0e365f9730782148c6f58444dcf470e8

commit 7f4ddc2a0e365f9730782148c6f58444dcf470e8
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Oct 13 16:09:32 2016

Move WebTextInputType and WebTextInputInfo into platform.

Moving these types into platform will allow the Editor class to provide
the implementation as opposed to a wrapper inside WebViewImpl which
it is today.

BUG=634330
TBR=shuchen@chromium.org, boliu@chromium.org

Review-Url: https://codereview.chromium.org/2411973004
Cr-Commit-Position: refs/heads/master@{#425050}

[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/content/browser/DEPS
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/content/browser/renderer_host/ime_adapter_android.cc
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/content/renderer/render_widget.h
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/third_party/WebKit/Source/platform/BUILD.gn
[rename] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/third_party/WebKit/Source/platform/WebTextInputInfo.cpp
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/third_party/WebKit/public/BUILD.gn
[rename] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/third_party/WebKit/public/platform/WebTextInputInfo.h
[rename] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/third_party/WebKit/public/platform/WebTextInputType.h
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/third_party/WebKit/public/web/WebWidget.h
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/ui/base/ime/text_input_flags.h
[modify] https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8/ui/base/ime/text_input_type.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4dd5befeeaffe92aa6973024ccc9537eddae3e3

commit c4dd5befeeaffe92aa6973024ccc9537eddae3e3
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Oct 25 15:11:10 2016

Define WebTextInputMode as a enum in the public API.

Change the WebString being passed back into at the public API layer
into an enum and move the string->enum conversion into blink.

Add missing enum types that match the spec as it is today. We are still
working out what we will ship.

BUG=634330
TBR=shuchen@chromium.org

Review-Url: https://codereview.chromium.org/2422663002
Cr-Commit-Position: refs/heads/master@{#427352}

[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/content/child/assert_matching_enums.cc
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/content/renderer/render_widget.cc
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/content/renderer/render_widget.h
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/core/CoreInitializer.cpp
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/core/editing/InputMethodController.h
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/core/editing/InputModeNames.in
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/platform/WebTextInputInfo.cpp
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_email.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_full_width_latin.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_kana.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_kana_name.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_kata_kana.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_latin.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_latin_name.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_latin_prose.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_numeric.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_tel.html
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/Source/web/tests/data/input_mode_type_url.html
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/public/platform/WebTextInputInfo.h
[add] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/third_party/WebKit/public/platform/WebTextInputMode.h
[modify] https://crrev.com/c4dd5befeeaffe92aa6973024ccc9537eddae3e3/ui/base/ime/text_input_mode.h

Labels: Proj-Fugu

Sign in to add a comment