vectorize translate bubble icon |
||
Issue descriptionCurrently using the attached (1x dsf), behind a flag. This was added in May. New resources should not be added as pngs. We should probably just be using gfx::VectorIconId::TRANSLATE
,
Aug 4 2016
CreateVectorIcon takes a color param. If you need multiple colors in one icon you can define them in the .icon file.
,
Aug 4 2016
The attached icon is super old. We don't use that any more. If we are talking about the omnibar icon, we should use the attached. If we are talking about the icon that appears inside the bubble, we should use the Google Translate product icon.
,
Aug 4 2016
Yes, we are talking about the one inside the bubble. pendar@, can you link to the specific icon you're talking about?
,
Aug 4 2016
Just to reconfirm, you're talking about the icon here: https://screenshot.googleplex.com/YS7Y5BncriO If so, you can download the SVG from go/icons: https://icons.googleplex.com/#icon=logo_translate&search=translate
,
Aug 5 2016
oh right sorry, I was confused and attached the wrong image. Should be this one. I actually don't think we have to do anything here (sticking with png is fine for more complicated icons like this). |
||
►
Sign in to add a comment |
||
Comment 1 by ftang@chromium.org
, Aug 4 2016I believe this is the one for Mac chromium src/ios/chrome/app/theme/ios_theme_resources.grd 29: <structure type="chrome_scaled_image" name="IDR_IOS_INFOBAR_SAVE_PASSWORD" file="infobar_save_password.png" /> 30: <structure type="chrome_scaled_image" name="IDR_IOS_INFOBAR_TRANSLATE" file="infobar_translate.png" /> 31: </structures> chromium src/ios/chrome/browser/translate/chrome_ios_translate_client.mm 138: int ChromeIOSTranslateClient::GetInfobarIconID() const { 139: return IDR_IOS_INFOBAR_TRANSLATE; 140: } How do you make a COLOR version of vertorize icon ? That is what currently used on Mac for many icons