New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634328 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 505953



Sign in to add a comment

vectorize translate bubble icon

Project Member Reported by est...@chromium.org, Aug 4 2016

Issue description

Currently using the attached (1x dsf), behind a flag.

This was added in May. New resources should not be added as pngs. We should probably just be using gfx::VectorIconId::TRANSLATE
 
infobar_translate.png
751 bytes View Download

Comment 1 by ftang@chromium.org, Aug 4 2016

Cc: pendar@google.com
I believe this is the one for Mac
chromium src/ios/chrome/app/theme/ios_theme_resources.grd
    29:   <structure type="chrome_scaled_image" name="IDR_IOS_INFOBAR_SAVE_PASSWORD" file="infobar_save_password.png" />
    30:   <structure type="chrome_scaled_image" name="IDR_IOS_INFOBAR_TRANSLATE" file="infobar_translate.png" />
    31: </structures>
chromium src/ios/chrome/browser/translate/chrome_ios_translate_client.mm
   138: int ChromeIOSTranslateClient::GetInfobarIconID() const {
   139:   return IDR_IOS_INFOBAR_TRANSLATE;
   140: }

How do you make a COLOR version of vertorize icon ? That is what currently used on Mac for many icons
CreateVectorIcon takes a color param. If you need multiple colors in one icon you can define them in the .icon file.

Comment 3 by pendar@google.com, Aug 4 2016

The attached icon is super old. We don't use that any more. 
If we are talking about the omnibar icon, we should use the attached.
If we are talking about the icon that appears inside the bubble, we should use the Google Translate product icon.
omnibox_translate-2x.svg
2.3 KB Download
Yes, we are talking about the one inside the bubble. pendar@, can you link to the specific icon you're talking about?

Comment 5 by pendar@google.com, Aug 4 2016

Just to reconfirm, you're talking about the icon here:
https://screenshot.googleplex.com/YS7Y5BncriO

If so, you can download the SVG from go/icons:
https://icons.googleplex.com/#icon=logo_translate&search=translate

Status: WontFix (was: Assigned)
oh right sorry, I was confused and attached the wrong image. Should be this one.

I actually don't think we have to do anything here (sticking with png is fine for more complicated icons like this).
ui_resources_default_200_percent_common_translate.png
3.1 KB View Download

Sign in to add a comment