cros_sdk should detect & reject running in a chromium checkout |
||||
Issue descriptionsometimes people try to run `cros_sdk` when they're in a chromium checkout. we should reject this up front. we should also handle the missing chromiumos-overlay better ... currently we just try to fetch a tarball with version "<unknown>" anyways and then display a confusing message. example: https://groups.google.com/a/chromium.org/d/topic/chromium-os-dev/cmZ2Joxao58/discussion
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/040a116ba6934b99eef00f6fe40a73077a1035f6 commit 040a116ba6934b99eef00f6fe40a73077a1035f6 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Jun 30 17:28:08 2017 cros_sdk: Improve error message outside cros root When running cros_sdk outside a chromium os root but in a directory containing .repo or .gclient (e.g. chromium), the current error message is a strange traceback referring to bad URLs. Check for the underlying error case and give a better error message. BUG= chromium:634317 TEST=Copied patched cros_sdk.py into a chromium checkout and ran there. Change-Id: Ia1b43ed9f4370a850c7f5ab64c23e6db7eada75d Reviewed-on: https://chromium-review.googlesource.com/556153 Commit-Ready: Benjamin Gordon <bmgordon@chromium.org> Tested-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/040a116ba6934b99eef00f6fe40a73077a1035f6/scripts/cros_sdk.py
,
Jun 30 2017
,
Jul 5 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sjg@chromium.org
, May 24 2017Owner: bmgordon@chromium.org