Add alerts for v8.browsing_mobile, v8.browsing_desktop and new memory metrics. |
|||
Issue descriptionCould you please add the following alerts? For all benchmarks that use memory metric (system_health.memory_mobile, system_health.memory_desktop, v8.browsing_mobile, v8.browsing_desktop): - memory:chrome:renderer_processes:reported_by_chrome:v8:allocated_by_malloc_peak_size_max - (after https://codereview.chromium.org/2204213002/ lands, I will ping this thread when it happens): - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:code_space:allocated_objects_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:code_space:allocated_objects_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:code_space:effective_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:large_object_space:allocated_objects_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:large_object_space:allocated_objects_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:large_object_space:effective_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:large_object_space:effective_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:allocated_objects_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:allocated_objects_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:effective_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:effective_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:new_space:allocated_objects_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:new_space:allocated_objects_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:new_space:effective_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:new_space:effective_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:old_space:allocated_objects_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:old_space:allocated_objects_size_max - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:old_space:effective_size_avg - memory:chrome:renderer_processes:reported_by_chrome:v8:heap:old_space:effective_size_max For v8.browsing_mobile, v8.browsing_desktop: - the standard memory metric alerts (i.e. ones used for system_health.memory_mobile, system_health.memory_desktop). - v8-gc-full-mark-compactor_avg - v8-gc-full-mark-compactor_max - v8-gc-full-mark-compactor_sum - v8-gc-incremental-finalize_avg - v8-gc-incremental-finalize_max - v8-gc-incremental-finalize_sum - v8-gc-incremental-step_avg - v8-gc-incremental-step_max - v8-gc-incremental-step_sum - v8-gc-memory-mark-compactor_avg - v8-gc-memory-mark-compactor_max - v8-gc-memory-mark-compactor_sum - v8-gc-latency-mark-compactor_avg - v8-gc-latency-mark-compactor_max - v8-gc-latency-mark-compactor_sum - v8-gc-scavenger_avg - v8-gc-scavenger_max - v8-gc-scavenger_sum - v8-gc-total_avg - v8-gc-total_max - v8-gc-total_sum
,
Aug 9 2016
Sorry for the delay here--should this go to the v8 perf sheriff or the chromium perf sheriff? This is a very large number of alerts, would you be willing to do a trial rotation where you get emails on the alerts to make sure it's manageable before handing it off to a larger rotation?
,
Aug 9 2016
I suggest you set up a temporary rotation first. We received tens of SH alerts in the first weeks after we set up the alerts.
,
Aug 25 2016
The alerts should go to V8 memory sheriff rotation.
,
Aug 26 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by u...@chromium.org
, Aug 5 2016