In Find in page, Next button is enabled even for invalid text input.
Reported by
vvishwak...@etouch.net,
Aug 4 2016
|
|||||||
Issue descriptionVersion: 54.0.2817.0 (Official Build) cd4d5eb8d957a3ce7ccf0fa60243eccd8ba47691-refs/heads/master@{#409416} (64-bit) OS: Mac (10.10.5, 10.11.4) What steps will reproduce the problem? 1) Launch chrome, go to any webpage and press Cmd+F (to open Find in page) 2) Enter some invalid text and click on 'Next' button. 3) Click anywhere on the page, then press Cmd+F, click on 'Next' button and observe. 'Next' button is not disabled for invalid input. 'Next' button should be disabled for invalid entry. This is a Non-Regression issue seen from M-30 series (30.0.1549.0) Note: Issue is not seen on Windows and Linux OS.
,
Aug 19 2016
,
Jun 11 2017
Proposed fix submitted in https://codereview.chromium.org/2928333002/ Reviewers welcome.
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91d01230acfaf11ce9ef59d1af6e9ce232cc9e01 commit 91d01230acfaf11ce9ef59d1af6e9ce232cc9e01 Author: carloschilazo <carloschilazo@gmail.com> Date: Fri Aug 04 12:49:15 2017 Mac:Dont always enable findbar buttons when restoring focus with search string Avoids enabling findbar buttons when there is no search match. TEST=On mac: Search for something not in page, verify next/prev buttons disabled due to no results, focus away from findbar, do ctrl-f and verify buttons remain disabled. BUG= 634289 Review-Url: https://codereview.chromium.org/2928333002 Cr-Commit-Position: refs/heads/master@{#492002} [modify] https://crrev.com/91d01230acfaf11ce9ef59d1af6e9ce232cc9e01/chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm [modify] https://crrev.com/91d01230acfaf11ce9ef59d1af6e9ce232cc9e01/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
,
Aug 7 2017
Merged ^ Whoever can please update the issue status.
,
Jul 10
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ranjitkan@chromium.org
, Aug 4 2016