New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634254 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Tabs in header section appear blank in "newindiabank.in"

Reported by adha...@etouch.net, Aug 4 2016

Issue description

Chrome Version:54.0.2817.0 (Official Build) cd4d5eb8d957a3ce7ccf0fa60243eccd8ba47691-refs/heads/master@{#409416}(32/64-bit)
OS: Windows (7,8,10), Mac (10.10.5, 10.11.5), Linux (14.04 LTS).

Test url:http://www.newindiabank.in/

What steps will reproduce the problem?
(1)Launch chrome and navigate to the above url.
(2)Observe tabs in header section.

Actual:Tabs in header section appear blank.(Appears only after inspect via context menu)

Expected:Tabs in header section should not appear blank.

This is a Regression issue broken in M-54,will soon update other info.

Good build:54.0.2816.0
Bad build:54.0.2817.0


 
Actual result.mp4
959 KB View Download
Expected result.mp4
320 KB View Download

Comment 1 by adha...@etouch.net, Aug 4 2016

Owner: sashab@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/b2a0b3727c071668ad72461c9d77e10dc579e407..b1205edbd51bf546deb4296a963669c918b6f596?pretty=fuller&n=100

Suspecting:r409143?

Kindly help to re-assign if your change is not the cause for this issue.
Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.

Comment 3 by tkent@chromium.org, Aug 4 2016

Components: -Blink Blink>CSS
Status: Started (was: Assigned)
Yup, this is definitely caused by my change, and should be a beta blocker. Investigating now.
Cc: esprehn@chromium.org r...@opera.com
This is really tough to diagnose... Clearly there is a recalc call missing somewhere, but finding it is difficult.

The only things I can see that are unique about this page is that it uses visibility: inherit (which may have strange behavior, but none that I can repro locally), and has 2 shadow roots that independent inherited changes to visibility propagate through, although the bug isn't fixed by crrev.com/2212223002.

The only way I can get this to work by disabling the fast-path entirely.

Rune@/esprehn@, any ideas? Attached a somewhat minimized test case... It's hard  to further minimize because the page uses some kind of library, awmlib2.js, which is minified and does all kinds of crazy things.
india_test_page.html
4.1 KB View Download
Labels: ReleaseBlock-Dev
This is dev blocker, you caused two regressions by touching something core to the style engine. That means a the real breakage is possibly much worse. Please revert while we understand what happened. :)

Leaving canary in an unknown broken state for days is bad.

Comment 7 by r...@opera.com, Aug 5 2016

Minimal test.
inherit.html
250 bytes View Download

Comment 8 by r...@opera.com, Aug 5 2016

I've triggered a revert from the CL.

Comment 9 by r...@opera.com, Aug 5 2016

The generated applyInherit... methods sets setIsInherited to false instead of true.

Labels: -ReleaseBlock-Beta
Removing the RB-Beta as per # 6
This is working fine on current canary build 54.0.2823.0 - Win7/64 bit, Mac OSX 10.11.5 & Linux/Ubuntu 14.04
634254 on Win7.PNG
429 KB View Download
Labels: Needs-Feedback
Can you please mark this bug as Fixed ?

Comment 14 by r...@opera.com, Aug 8 2016

Status: Fixed (was: Started)
Labels: -Needs-Feedback TE-Verified-54.0.2823.0 TE-Verified-M54 TE-Verified-54.0.2824.0
Rechecked this on chrome version 54.0.2824.0 on Windows 7 and MAC 10.11.6, 54.0.2823.0 on Ubuntu 14.04. Fix is working as intended. Header links are properly displayed. Adding TE-Verified labels.

Thanks.!

Sign in to add a comment