Tabs in header section appear blank in "newindiabank.in"
Reported by
adha...@etouch.net,
Aug 4 2016
|
||||||||||
Issue descriptionChrome Version:54.0.2817.0 (Official Build) cd4d5eb8d957a3ce7ccf0fa60243eccd8ba47691-refs/heads/master@{#409416}(32/64-bit) OS: Windows (7,8,10), Mac (10.10.5, 10.11.5), Linux (14.04 LTS). Test url:http://www.newindiabank.in/ What steps will reproduce the problem? (1)Launch chrome and navigate to the above url. (2)Observe tabs in header section. Actual:Tabs in header section appear blank.(Appears only after inspect via context menu) Expected:Tabs in header section should not appear blank. This is a Regression issue broken in M-54,will soon update other info. Good build:54.0.2816.0 Bad build:54.0.2817.0
,
Aug 4 2016
Adding release block label, please undo if not the case.
,
Aug 4 2016
,
Aug 5 2016
Yup, this is definitely caused by my change, and should be a beta blocker. Investigating now.
,
Aug 5 2016
This is really tough to diagnose... Clearly there is a recalc call missing somewhere, but finding it is difficult. The only things I can see that are unique about this page is that it uses visibility: inherit (which may have strange behavior, but none that I can repro locally), and has 2 shadow roots that independent inherited changes to visibility propagate through, although the bug isn't fixed by crrev.com/2212223002. The only way I can get this to work by disabling the fast-path entirely. Rune@/esprehn@, any ideas? Attached a somewhat minimized test case... It's hard to further minimize because the page uses some kind of library, awmlib2.js, which is minified and does all kinds of crazy things.
,
Aug 5 2016
This is dev blocker, you caused two regressions by touching something core to the style engine. That means a the real breakage is possibly much worse. Please revert while we understand what happened. :) Leaving canary in an unknown broken state for days is bad.
,
Aug 5 2016
Minimal test.
,
Aug 5 2016
I've triggered a revert from the CL.
,
Aug 5 2016
The generated applyInherit... methods sets setIsInherited to false instead of true.
,
Aug 5 2016
Removing the RB-Beta as per # 6
,
Aug 7 2016
FYI: Thee revert was landed in https://chromium.googlesource.com/chromium/src/+/bf9f7aeb812949577490b55e40dd36c8eca7b8f9
,
Aug 8 2016
This is working fine on current canary build 54.0.2823.0 - Win7/64 bit, Mac OSX 10.11.5 & Linux/Ubuntu 14.04
,
Aug 8 2016
Can you please mark this bug as Fixed ?
,
Aug 8 2016
,
Aug 9 2016
Rechecked this on chrome version 54.0.2824.0 on Windows 7 and MAC 10.11.6, 54.0.2823.0 on Ubuntu 14.04. Fix is working as intended. Header links are properly displayed. Adding TE-Verified labels. Thanks.! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by adha...@etouch.net
, Aug 4 2016Status: Assigned (was: Unconfirmed)