New issue
Advanced search Search tips

Issue 634240 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Aug 2016
Cc:
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failure in NQE when checking the load timing info

Project Member Reported by tbansal@chromium.org, Aug 4 2016 
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dbg%29%20tester/builds/2914/steps/browser_tests%20on%20Windows-7-SP1/logs/CrSettingsMainPageTest.All
shows a DCHECK failing in NQE because load timing info is null.

This code is used only for recording the UMA metric. The simple fix is to replace the DCHECK by if conditional.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8322dc34d8b35270fd642fa01d96c127ebe4ac3b

commit 8322dc34d8b35270fd642fa01d96c127ebe4ac3b
Author: tbansal <tbansal@chromium.org>
Date: Thu Aug 04 07:56:43 2016

Fix crash in NQE: Replace DCHECK by an if-conditional

https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dbg%29%20tester/builds/2914/steps/browser_tests%20on%20Windows-7-SP1/logs/CrSettingsMainPageTest.All
shows a DCHECK failing in NQE because load timing info
is null.

This CL replaces the DCHECK by an if-conditional.

TBR=bengr@chromium.org
BUG= 634240 

Review-Url: https://codereview.chromium.org/2208733004
Cr-Commit-Position: refs/heads/master@{#409735}

[modify] https://crrev.com/8322dc34d8b35270fd642fa01d96c127ebe4ac3b/net/nqe/network_quality_estimator.cc

Comment 2 by tbansal@chromium.org, Aug 4 2016

Cc: thakis@chromium.org
Status: Fixed (was: Started)
This bug was caused by https://codereview.chromium.org/2204383002/ which enabled a code path that was previously unused. Since this code only logs the metrics, the only affect is that some of the earlier M-54 Chrome versions may end up reporting bad data.

Comment 3 by tbansal@chromium.org, Feb 14 2017

Components: Internals>Network>NetworkQuality
►

Sign in to add a comment