New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634237 link

Starred by 3 users
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Back navigation via 'Alt+Left arrow' keys is not proper after giving Print command on chrome://md-settings.

Reported by jshan...@etouch.net, Aug 4 2016 
Chrome Version: 54.0.2817.0 (Official Build) cd4d5eb8d957a3ce7ccf0fa60243eccd8ba47691-refs/heads/master@{#409416}-32/64 bit
OS: Windows (7,8,8.1,10), Linux(14.04 LTS)

Steps:
1. Launch Chrome and navigate to chrome://md-settings/advanced.
2. Scroll down the page and click on 'Reset' (Reset overlay appears) and give Print command.
3. Press 'Alt+ Left arrow' keys and observe.

Actual: Print preview does not close after pressing 'Alt+ Left arrow' keys, also back navigation of page is observed in background.

Expected: Print preview should close after pressing 'Alt+ Left arrow' keys and then back navigation of page should be seen.

This is a regression issue broken in M-54,will soon update bisect info.

Good build: 54.0.2813.0
Bad build: 54.0.2814.0

Note: This issue is not seen on Mac OS.
Actual_video.mp4
521 KB View Download
Expected_video.mp4
430 KB View Download

Comment 1 by jshan...@etouch.net, Aug 4 2016

Components: UI>Browser>PrintPreview
Labels: hasbisect
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/b13b5d875d636d36617943e2dfb2dcf2831cc28a..85092cd8d7f4576aabaf2b9de9064978319c7388?pretty=fuller&n=100

Suspecting: r408860 ?

Please help to re-assign if your change is not the cause for this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d65b6608c1349ba70606565b2bed9ff8b016473a

commit d65b6608c1349ba70606565b2bed9ff8b016473a
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Aug 09 17:12:00 2016

Fix Print Preview Alt + Left Arrow breakage

Fixing print preview closing in g-mail bug caused ALT + left
arrow to break for certain cases. Changed condition for not
closing dialog to be more specific.

BUG= 634237 

Review-Url: https://codereview.chromium.org/2215063002
Cr-Commit-Position: refs/heads/master@{#410717}

[modify] https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a/chrome/browser/printing/print_preview_dialog_controller.cc
[modify] https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a/chrome/browser/printing/print_preview_dialog_controller_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5290712a92d8c235d1d6e704fa5a34937a57e56a

commit 5290712a92d8c235d1d6e704fa5a34937a57e56a
Author: foolip <foolip@chromium.org>
Date: Wed Aug 10 13:12:19 2016

Revert of Fix Print Preview Alt + Left Arrow breakage (patchset #5 id:80001 of https://codereview.chromium.org/2215063002/ )

Reason for revert:
PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation is flaky on mac_chromium_rel_ng:

PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (run #1):
[ RUN      ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation
[41473:1287:0810/034931:18891494657941:ERROR:native_widget_mac.mm(285)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../chrome/browser/printing/print_preview_dialog_controller_unittest.cc:240: Failure
Expected: (tiger_barb_preview_dialog) != (tiger_preview_dialog_2), actual: 0x7f9efc809a00 vs 0x7f9efc809a00
[  FAILED  ] PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation (89 ms)

BUG= 636234 

Original issue's description:
> Fix Print Preview Alt + Left Arrow breakage
>
> Fixing print preview closing in g-mail bug caused ALT + left
> arrow to break for certain cases. Changed condition for not
> closing dialog to be more specific.
>
> BUG= 634237 
>
> Committed: https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a
> Cr-Commit-Position: refs/heads/master@{#410717}

TBR=thestig@chromium.org,rbpotter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 634237 

Review-Url: https://codereview.chromium.org/2232853002
Cr-Commit-Position: refs/heads/master@{#411030}

[modify] https://crrev.com/5290712a92d8c235d1d6e704fa5a34937a57e56a/chrome/browser/printing/print_preview_dialog_controller.cc
[modify] https://crrev.com/5290712a92d8c235d1d6e704fa5a34937a57e56a/chrome/browser/printing/print_preview_dialog_controller_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2224d2c0c1863c313fa3d4fb510091bc067c1d3e

commit 2224d2c0c1863c313fa3d4fb510091bc067c1d3e
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Aug 17 23:54:00 2016

Fix Print Preview Alt + Left Arrow breakage

Fixing print preview closing in g-mail bug caused ALT + left
arrow to break for certain cases. Changed condition for not
closing dialog to be more specific.

BUG= 636234 ,  634237 

Committed: https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a
Review-Url: https://codereview.chromium.org/2215063002
Cr-Original-Commit-Position: refs/heads/master@{#410717}
Cr-Commit-Position: refs/heads/master@{#412697}

[modify] https://crrev.com/2224d2c0c1863c313fa3d4fb510091bc067c1d3e/chrome/browser/printing/print_preview_dialog_controller.cc
[modify] https://crrev.com/2224d2c0c1863c313fa3d4fb510091bc067c1d3e/chrome/browser/printing/print_preview_dialog_controller_unittest.cc

Comment 5 by rbpotter@chromium.org, Aug 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment