New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634236 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser crash is seen upon clicking on any link in chrome://history/syncedTabs page in emulated view.

Project Member Reported by bj00129...@techmahindra.com, Aug 4 2016

Issue description

Version:54.0.2817.0 Dev
OS: Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1)Signin to chrome with valid credentials>>Navigate to chrome://history/syncedTabs page>> Open devtools and emulate>> Now click on any link and observe.

Expected:Should be able to open link without any browser crash.
Actual: Instead browser crash is seen upon clicking on link in chrome://history/syncedTabs page in emulated view.

Crash ids: ea7102c200000000, 6008c2fe00000000

This is Regression issue broken in M-54. Will update bisect info soon.
Attaching screen-cast for reference.

 
Actual_Syntabscrash-1.ogv
2.9 MB View Download

Comment 1 by ajha@chromium.org, Aug 4 2016

Labels: ReleaseBlock-Beta OS-Mac
Status: Untriaged (was: Unconfirmed)
Reproducible on Mac OS 10.11.5 on the latest canary(54.0.2817.0) as well.
Labels: -Needs-Bisect hasbisect
Owner: tsergeant@chromium.org
Status: Assigned (was: Untriaged)
Unable to do tool bisect as issue is seen only after signing into chrome which can't be done in chromium builds.

Manual Bisect info:
Good build:54.0.2811.0 Dev
Bad build:54.0.2812.0 Dev

CHANGELOG:
https://chromium.googlesource.com/chromium/src/+log/54.0.2811.0..54.0.2812.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2195593002 from manual changelog.

@tsergeant: Please help in re-assigning if it is not related to your change.

Project Member

Comment 3 by sheriffbot@chromium.org, Aug 4 2016

Labels: Fracas FoundIn-M-54
Users experienced this crash on the following builds:

Linux Dev 54.0.2816.0 -  6.94 CPM, 2 reports, 2 clients (signature webui::GetDispositionFromClick)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Status: Started (was: Assigned)
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e

commit ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Aug 09 06:27:13 2016

MD History: Fix crash when opening Synced Tab links with touch

The event handler for synced tab clicks needs to know what modifier keys
were pressed during the click, but Polymer tap events do not include this
information from touch events. Instead, this changes the handler to
listen to a plain 'click' event, which will always include this
information.

BUG= 634236 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2219753002
Cr-Commit-Position: refs/heads/master@{#410597}

[modify] https://crrev.com/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e/chrome/browser/resources/md_history/browser_service.js
[modify] https://crrev.com/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e/chrome/browser/resources/md_history/constants.js
[modify] https://crrev.com/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e/chrome/browser/resources/md_history/synced_device_card.js
[modify] https://crrev.com/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e/chrome/test/data/webui/md_history/history_synced_tabs_test.js

Status: Fixed (was: Started)

Sign in to add a comment