Merge button is missing on gerrit for project linux-fpga-chameleon |
|||
Issue descriptionThere might be recent change on gerrit. I found that the merge button is missing for CL of project linux-fpga-chameleon For example https://chromium-review.googlesource.com/#/c/343395/ Before, there was a merge button that I can hit to merge a CL. The permission page as attached shows that chromeos-chameleon group should have push merge commit permission. Not sure what was changed recently...
,
Aug 9 2016
cychiang@: What is linux-platform-chameleon? It appears to be a chromeos project, so why is it not in the chromiumos/ namespace? Why do all of the normal devs have force-push permissions? I believe the correct solution here is to make it inherit ACLs from the chromiumos/ project, rather than directly from All-Projects. FWIW, the "push merge" permission has nothing to do with the existence of a "Merge" button in the UI; that button's existence is determined by the submit-strategy (merge, cherry-pick, or rebase) and whether or not you have permission to Submit. Dave, assigning back to you as the current git admin, since I'm 90% sure that just changing the project inheritance is the right thing to do.
,
Aug 9 2016
Hi agable@, linux-platform-chameleon is our fork of https://github.com/altera-opensource/linux-socfpga, which is the kernel for an FPGA board we use for ChromeOS testing: https://www.chromium.org/chromium-os/testing/chamelium. History of the repo setup is in https://bugs.chromium.org/p/chromium/issues/detail?id=572809#c9. "Why do all of the normal devs have force-push permissions?" --> I am not sure. Ideally we would like to give force-push permission to only member of chromeos-chameleon. Sorry I am not familiar with the ACL setting, but making linux-platform-chameleon inherit ACLs from chromiumos project seems right to me. Thank you very much for the help!
,
Aug 10 2016
Thanks Aaron! I've changed linux-fpga-chameleon to inherit permissions from chromeos-chameleon. > Ideally we would like to give force-push permission to only member of chromeos-chameleon. Yep, that's how it's configured now - only chromeos-chameleon has force push permissions.
,
Aug 10 2016
Great! Now I can see the submit button. Thank you agable@ and dsansome@ ! Mark as verified! |
|||
►
Sign in to add a comment |
|||
Comment 1 by dsansome@chromium.org
, Aug 9 2016Status: Assigned (was: Untriaged)