New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634213 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Merge button is missing on gerrit for project linux-fpga-chameleon

Project Member Reported by cychiang@chromium.org, Aug 4 2016

Issue description

There might be recent change on gerrit.
I found that the merge button is missing for CL of project linux-fpga-chameleon
For example https://chromium-review.googlesource.com/#/c/343395/
Before, there was a merge button that I can hit to merge a CL.

The permission page as attached shows that chromeos-chameleon group should have push merge commit permission. Not sure what was changed recently...

 
Screenshot from 2016-08-04 11:26:51.png
321 KB View Download
Owner: smut@chromium.org
Status: Assigned (was: Untriaged)
I don't seem to have permission to access https://chromium-review.googlesource.com/#/admin/projects/linux-fpga-chameleon,access (even though i'm in chrome-git-admins).

It looks like smut created this repo: any ideas?
Cc: smut@chromium.org
Owner: dsansome@chromium.org
cychiang@: What is linux-platform-chameleon? It appears to be a chromeos project, so why is it not in the chromiumos/ namespace? Why do all of the normal devs have force-push permissions?

I believe the correct solution here is to make it inherit ACLs from the chromiumos/ project, rather than directly from All-Projects.

FWIW, the "push merge" permission has nothing to do with the existence of a "Merge" button in the UI; that button's existence is determined by the submit-strategy (merge, cherry-pick, or rebase) and whether or not you have permission to Submit.

Dave, assigning back to you as the current git admin, since I'm 90% sure that just changing the project inheritance is the right thing to do.
Hi agable@, linux-platform-chameleon is our fork of https://github.com/altera-opensource/linux-socfpga, which is the kernel for an FPGA board we use for ChromeOS testing: https://www.chromium.org/chromium-os/testing/chamelium.

History of the repo setup is in https://bugs.chromium.org/p/chromium/issues/detail?id=572809#c9.

"Why do all of the normal devs have force-push permissions?" --> I am not sure.
Ideally we would like to give force-push permission to only member of chromeos-chameleon.

Sorry I am not familiar with the ACL setting, but making linux-platform-chameleon inherit ACLs from chromiumos project seems right to me.
Thank you very much for the help!


Comment 4 by dsansome@google.com, Aug 10 2016

Thanks Aaron!  I've changed linux-fpga-chameleon to inherit permissions from chromeos-chameleon.

> Ideally we would like to give force-push permission to only member of chromeos-chameleon.

Yep, that's how it's configured now - only chromeos-chameleon has force push permissions.
Status: Verified (was: Assigned)
Great! Now I can see the submit button.
Thank you agable@ and dsansome@ !
Mark as verified!

Sign in to add a comment