New issue
Advanced search Search tips

Issue 634208 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 609258



Sign in to add a comment

Figure out when downloaded WebAPKs should be deleted

Project Member Reported by pkotw...@chromium.org, Aug 4 2016

Issue description

Figure out when downloaded WebAPKs should be deleted


 
Labels: OS-Android

Comment 2 by hanxi@chromium.org, Sep 1 2016

Since WebApkInstaller already knows when the installation is complete or got canceled, we can delete the downloaded apk then.
Note to self: We need to handle the case of the user terminating Chrome prior to the WebAPK getting installed. I do not think that WebApkInstaller gets notified if the install gets cancelled due to Chrome being terminated
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0eca90e1ae6168837a85f01a644b729d326f67

commit 3f0eca90e1ae6168837a85f01a644b729d326f67
Author: hanxi <hanxi@chromium.org>
Date: Wed Sep 28 03:49:25 2016

Download WebAPK into WebAPK-specifc directory, and delete all cached
APKs before downloading a new one.

BUG= 634208 

Review-Url: https://codereview.chromium.org/2364133002
Cr-Commit-Position: refs/heads/master@{#421439}

[modify] https://crrev.com/3f0eca90e1ae6168837a85f01a644b729d326f67/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/3f0eca90e1ae6168837a85f01a644b729d326f67/chrome/browser/android/webapk/webapk_installer.h

Status: Fixed (was: Untriaged)

Sign in to add a comment