New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634198 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 595608



Sign in to add a comment

Update navigator.share API to match draft specs

Project Member Reported by mgiuca@chromium.org, Aug 4 2016

Issue description

Currently it just takes 2 arguments (title and text). Update to match the draft interface here:
https://github.com/WICG/web-share/blob/master/docs/interface.md
 
I started work on this:
https://codereview.chromium.org/2211693002
but feel free to take over.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0ccc25512095b79db124b3e8c733756735ccc9

commit 4d0ccc25512095b79db124b3e8c733756735ccc9
Author: sammc <sammc@chromium.org>
Date: Mon Aug 08 04:01:57 2016

Update navigator.share API to match draft specs.

This replaces the title and text string parameters with a ShareData
dictionary optionally containing title, text and URL; the URL field is
currently ignored.

BUG= 634198 

Review-Url: https://codereview.chromium.org/2207343002
Cr-Commit-Position: refs/heads/master@{#410297}

[modify] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/LayoutTests/webshare/share-arity.html
[modify] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/LayoutTests/webshare/share-error.html
[modify] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/LayoutTests/webshare/share-success.html
[modify] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/LayoutTests/webshare/share-types.html
[modify] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/Source/modules/webshare/NavigatorShare.h
[modify] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/Source/modules/webshare/NavigatorShare.idl
[add] https://crrev.com/4d0ccc25512095b79db124b3e8c733756735ccc9/third_party/WebKit/Source/modules/webshare/ShareData.idl

Status: Fixed (was: Assigned)

Sign in to add a comment