New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634196 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Put a use_titlecase version of string resources for Translate bubble on Mac

Project Member Reported by ftang@chromium.org, Aug 4 2016

Issue description

OS: Mac

Currently the string resources we use for Mac Translate Bubble does not include the use_titlecase version. We need to for those string in chrome/app/generated_resources.grd
 

Comment 1 by ftang@chromium.org, Aug 4 2016

Components: UI>Browser>Translate

Comment 2 by ftang@chromium.org, Aug 4 2016

The following string need use_title and not_use_title

IDS_TRANSLATE_BUBBLE_ACCEPT
IDS_TRANSLATE_BUBBLE_ADVANCED
IDS_TRANSLATE_BUBBLE_ALWAYS
IDS_TRANSLATE_BUBBLE_ALWAYS_DO_THIS
IDS_TRANSLATE_BUBBLE_BEFORE_TRANSLATE
IDS_TRANSLATE_BUBBLE_BEFORE_TRANSLATE_NEW
IDS_TRANSLATE_BUBBLE_COULD_NOT_TRANSLATE
IDS_TRANSLATE_BUBBLE_DENY
IDS_TRANSLATE_BUBBLE_LANGUAGE_SETTINGS
IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_LANG
IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_SITE
IDS_TRANSLATE_BUBBLE_OPTIONS_MENU_BUTTON
IDS_TRANSLATE_BUBBLE_PAGE_LANGUAGE
IDS_TRANSLATE_BUBBLE_REVERT
IDS_TRANSLATE_BUBBLE_TRANSLATED
IDS_TRANSLATE_BUBBLE_TRANSLATING
IDS_TRANSLATE_BUBBLE_TRANSLATION_LANGUAGE
IDS_TRANSLATE_BUBBLE_TRY_AGAIN

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d880380df21fffc1eb7c829ae8bea7a6f691963

commit 7d880380df21fffc1eb7c829ae8bea7a6f691963
Author: ftang <ftang@chromium.org>
Date: Fri Aug 05 22:26:34 2016

add use_titlecase for IDS_TRANSLATE_BUBBLE_*

BUG= 634196 

Review-Url: https://codereview.chromium.org/2214583002
Cr-Commit-Position: refs/heads/master@{#410192}

[modify] https://crrev.com/7d880380df21fffc1eb7c829ae8bea7a6f691963/chrome/app/generated_resources.grd

Comment 5 by ftang@chromium.org, Aug 8 2016

Status: Fixed (was: Assigned)
Components: -UI>Browser>Translate UI>Browser>Language>Translate

Sign in to add a comment