Issue 634173 link

Starred by 2 users

Issue metadata

Status:	WontFix
Owner:	ellyjo...@chromium.org
Closed:	Aug 2016
Components:	Internals>Views>Desktop
EstimatedDays:	----
NextAction:	----
OS:	Mac
Pri:	3
Type:	Bug
Proj-MacViews

Extension install dialog reappears by pressing Return after it's been dismissed

Project Member Reported by shrike@chromium.org, Aug 3 2016

Issue description

Version: 54.0.2817.0 Canary with MacViews enabled (and M52 stable)
OS: 10.11

What steps will reproduce the problem?
(1) Go to a page that offers an extension like: https://carlosjeurissen.com/black-menu-for-google
(2) Click the "Install" button
(3) Click the Cancel button to dismiss the dialog
(4) Press the Return key on your keyboard

What is the expected output?
A beep, or nothing at all.

What do you see instead?
The Extension install dialog becomes visible again.

I tried this in M52 stable and got the same results. That was with the Cocoa dialog, so this might not be a direct issue with MacViews or the dialog.

Assigning to ellyjones@ for triage.

Comment 1 by tapted@chromium.org, Aug 11 2016

I don't think we can change this. You can see what's going on if you `inspect` the install button and untick the `outline` property.

Buttons in the WebContent area receive focus on click (Native Mac buttons -- Views and Cocoa -- do not do this, but html buttons do). After dismissing the dialog, focus correctly goes back to the WebContents area, and it restores focus on the thing that was just clicked.

Then, also unlike Native Cocoa buttons, the web button is activated on *either* a Space or an Enter keypress (whereas on Cocoa only a dialog's default button is activated on an Enter, and you get NSBeep if there is no default button).

So I think the webcontent is behaving as it should, and we can't change that behaviour without breaking a lot of websites.