The two line checkbox rows get the 'two-line' height (56px). see attached file for screen shot.
This file has 56px rows where there are two lines and 44px rows where there is two lines. Does it look better or worse? Would it be better or worse if all the checkbox rows were 56px?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926 commit e2311a2b45fcabcb54d6f17a33c0a0ca09b90926 Author: dschuyler <dschuyler@chromium.org> Date: Tue Aug 09 21:28:23 2016 [MD settings] change height and width of checkboxes This CL makes settings-checkboxes change to a two-line height if the secondary text is set. The width of the checkbox is expanded to fill more of the row. A couple instances of .two-line used around a settings-checkbox have been removed. BUG= 634172 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2226963002 Cr-Commit-Position: refs/heads/master@{#410827} [modify] https://crrev.com/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926/chrome/browser/resources/settings/controls/settings_checkbox.html [modify] https://crrev.com/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926/chrome/browser/resources/settings/device_page/keyboard.html [modify] https://crrev.com/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/e2311a2b45fcabcb54d6f17a33c0a0ca09b90926/chrome/browser/resources/settings/settings_vars_css.html
Comment 1 by dschuyler@chromium.org
, Aug 8 201638.3 KB
38.3 KB View Download