New issue
Advanced search Search tips

Issue 634165 link

Starred by 2 users
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Update WebAudio tests for Android

Project Member Reported by rtoy@chromium.org, Aug 3 2016 
The following webaudio tests fail on Android.  These tests need to be updated to pass.

webaudio/audiobuffersource-loop-points.html
webaudio/audiolistener-automation-position.html
webaudio/audioparam-setTargetAtTime-continuous.html
webaudio/audioparam-update-value-attribute.html
webaudio/biquad-automation.html
webaudio/panner-automation-position.html
webaudio/realtimeanalyser-freq-data-smoothing.html
webaudio/realtimeanalyser-freq-data.html

All the failures are due to numerical differences between arm and x86.  Most tests just need to be updated with new thresholds, or just need to have fewer digits printed in the results.

The loop-points test shows at most 1 ulp difference between the expected and actual audio result.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bccb8801019378b11d077e4f5589959998a81e5

commit 3bccb8801019378b11d077e4f5589959998a81e5
Author: rtoy <rtoy@chromium.org>
Date: Wed Aug 10 17:46:52 2016

Update WebAudio layout tests for Android (arm32)

Update thresholds and print precision appropriately so that these
tests pass on Android.

The audiobuffersource-loop-points test differs by at most 1 bit in
the original reference so we're just adding an Android-specific result.

These tests were run on a Galaxy Nexus and pass there.

BUG= 634165 
TEST=

Review-Url: https://codereview.chromium.org/2200413005
Cr-Commit-Position: refs/heads/master@{#411076}

[add] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/platform/android/webaudio/audiobuffersource-loop-points-expected.wav
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/audiolistener-automation-position-expected.txt
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/audiolistener-automation-position.html
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/audioparam-setTargetAtTime-continuous-expected.txt
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/audioparam-setTargetAtTime-continuous.html
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/audioparam-update-value-attribute-expected.txt
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/audioparam-update-value-attribute.html
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/biquad-automation-expected.txt
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/biquad-automation.html
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/panner-automation-position-expected.txt
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/panner-automation-position.html
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-expected.txt
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-smoothing-expected.txt
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-smoothing.html
[modify] https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html

Comment 2 by rtoy@chromium.org, Aug 11 2016

Status: Fixed (was: Started)
►

Sign in to add a comment