New issue
Advanced search Search tips

Issue 634145 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: introduce view, view locations and view manager

Project Member Reported by pfeldman@chromium.org, Aug 3 2016

Issue description

This is to make most of our views extensible / provided.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/849de34fd9f7e2ffa76d2c0f2218d8a62232a711

commit 849de34fd9f7e2ffa76d2c0f2218d8a62232a711
Author: pfeldman <pfeldman@chromium.org>
Date: Wed Aug 03 23:11:00 2016

DevTools: introduce view locations, allow opening views by id.

BUG= 634145 

Review-Url: https://codereview.chromium.org/2205123003
Cr-Commit-Position: refs/heads/master@{#409654}

[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope.html
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/LayoutTests/inspector-enabled/tabbed-pane-closeable-persistence-restore.html
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/LayoutTests/inspector/animation/animation-empty-web-animations.html
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/LayoutTests/inspector/animation/animation-timeline.html
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/LayoutTests/inspector/animation/animation-web-anim-negative-start-time.html
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/devtools.gypi
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/animation/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/common/Console.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/components/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/devices/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/emulation/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/main/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/network/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/settings/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/sources/RevisionHistoryView.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/sources/module.json
[delete] https://crrev.com/f6c9e3c045096156be4a987b2b2a05110da14fe8/third_party/WebKit/Source/devtools/front_end/ui/Drawer.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
[add] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/ui/View.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/ui/Widget.js
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/ui/module.json
[modify] https://crrev.com/849de34fd9f7e2ffa76d2c0f2218d8a62232a711/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c58d14b485ad001da13adaced10dcdfeb6983c7a

commit c58d14b485ad001da13adaced10dcdfeb6983c7a
Author: pfeldman <pfeldman@chromium.org>
Date: Sat Aug 06 03:33:32 2016

DevTools: use view locations in the elements and sources sidebars.

BUG= 634145 

Review-Url: https://codereview.chromium.org/2217783002
Cr-Commit-Position: refs/heads/master@{#410260}

[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker-expected.txt
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/animation/animation-empty-web-animations.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/animation/animation-timeline.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/animation/animation-web-anim-negative-start-time.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/elements/accessibility/accessibility-pane-test.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/reveal-objects.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/devtools.gypi
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/resources/DatabaseTableView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/source_frame/FontView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/source_frame/ImageView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/ui/ThrottledView.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/ui/View.js
[delete] https://crrev.com/a4e73d2ea1b167d26c75e59e38625047b25d7eb3/third_party/WebKit/Source/devtools/front_end/ui/ViewContainers.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/ui/Widget.js
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/ui/module.json
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/front_end/ui/viewContainers.css
[modify] https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a/third_party/WebKit/Source/devtools/scripts/compile_frontend.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d

commit a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d
Author: pfeldman <pfeldman@chromium.org>
Date: Thu Aug 11 04:59:53 2016

DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars.

BUG= 634145 

Review-Url: https://codereview.chromium.org/2234193002
Cr-Commit-Position: refs/heads/master@{#411269}

[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/http/tests/inspector/debugger/fetch-breakpoints.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-after-suspension.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-script-first-stmt.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-xhr.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/xhr-breakpoints.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-break-program.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-step-from-framework.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/skip-pauses-until-reload.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/step-through-event-listeners.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-empty-event-listener.html
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/elements/module.json
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
[modify] https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d/third_party/WebKit/Source/devtools/front_end/ui/View.js

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c88c2032c2afd035c998da61abc0b92e4253803f

commit c88c2032c2afd035c998da61abc0b92e4253803f
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Aug 16 15:02:36 2016

DevTools: migrate sources panel sidebar to views.

BUG= 634145 

Review-Url: https://codereview.chromium.org/2238003002
Cr-Commit-Position: refs/heads/master@{#412236}

[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-breakpoints-1-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/debugger-reload-breakpoints-with-source-maps.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/set-breakpoint-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/set-conditional-breakpoint-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-change-variable.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/copy-stack-trace.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-expand-scope.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/reveal-not-skipped-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-2-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-3-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/selected-call-frame-after-formatting-source.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger/debug-inlined-scripts-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger/debug-inlined-scripts.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-minified-variables-evalution.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-proto-property.html
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/LayoutTests/inspector/sources/debugger/js-with-inline-stylesheets-expected.txt
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/sources/uiList.css
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/ui/Context.js
[modify] https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f/third_party/WebKit/Source/devtools/front_end/ui/View.js

Comment 6 by woxxom@gmail.com, Nov 2 2016

https://crrev.com/2234193002 added unconditional expansion of the call stack panel, which is problematic, please see  issue 661293 
Status: Fixed (was: Assigned)

Sign in to add a comment