Remove widget hierarchy methods for geometry |
|||||||
Issue description
IntRect convertToRootFrame(const IntRect&) const;
IntRect convertFromRootFrame(const IntRect&) const;
IntPoint convertToRootFrame(const IntPoint&) const;
IntPoint convertFromRootFrame(const IntPoint&) const;
FloatPoint convertFromRootFrame(const FloatPoint&) const;
virtual IntRect convertToContainingWidget(const IntRect&) const;
virtual IntRect convertFromContainingWidget(const IntRect&) const;
virtual IntPoint convertToContainingWidget(const IntPoint&) const;
virtual IntPoint convertFromContainingWidget(const IntPoint&) const;
// Virtual methods to convert points to/from child widgets
virtual IntPoint convertChildToSelf(const Widget*, const IntPoint&) const;
virtual IntPoint convertSelfToChild(const Widget*, const IntPoint&) const;
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0bdc84cb491d60466426626c0bd442965850569 commit a0bdc84cb491d60466426626c0bd442965850569 Author: chrishtr <chrishtr@chromium.org> Date: Thu Aug 04 06:46:44 2016 Delete FrameView::rectToCopyOnScroll. BUG=634143 Review-Url: https://codereview.chromium.org/2213553002 Cr-Commit-Position: refs/heads/master@{#409731} [modify] https://crrev.com/a0bdc84cb491d60466426626c0bd442965850569/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/a0bdc84cb491d60466426626c0bd442965850569/third_party/WebKit/Source/core/frame/FrameView.h [modify] https://crrev.com/a0bdc84cb491d60466426626c0bd442965850569/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
,
Aug 4 2016
,
Aug 12 2016
,
Oct 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01cc28757550adcf3eb436bab40ad67f251530c5 commit 01cc28757550adcf3eb436bab40ad67f251530c5 Author: wkorman <wkorman@chromium.org> Date: Sat Oct 01 04:54:45 2016 Update layout documentation re: coordinate systems and writing mode. BUG=634143 Review-Url: https://codereview.chromium.org/2380933004 Cr-Commit-Position: refs/heads/master@{#422298} [modify] https://crrev.com/01cc28757550adcf3eb436bab40ad67f251530c5/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h [modify] https://crrev.com/01cc28757550adcf3eb436bab40ad67f251530c5/third_party/WebKit/Source/core/layout/README.md
,
Apr 27 2017
Pass this bug to the architecture team that is working on issue 637460 ?
,
May 11 2017
Hi Joel, Chris asked to pass this to you.
,
May 11 2017
Can I clarify what work is still to be done on this bug? The original description lists 11 methods in FrameView without any description about what should be done to them. If the work is unclear, maybe it is best to close this bug, or mark it a duplicate of crbug.com/637460
,
May 12 2017
These methods duplicate other methods on the Layout tree. I'll just mark it as available, since I don't think it actually blocks removal of the widget tree.
,
Jun 12 2017
,
Jun 12 2017
I think this bug actually does block issue 637460 . The tasks necessary here are to migrate callsites of convertToRootFrame etc to use LayoutObject:LocalToAncestorQuad for the source and destination LayoutObjects that are implied by the use-case. I am happy to consult on the right way to do this for whoever picks up this bug.
,
Jun 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 4 2016